[None][test] Reduce Nemotron V3 Super/Ultra pre-merge test cases - #16122
Conversation
Consolidate Nemotron V3 Super/Ultra accuracy tests since both models share the same NemotronH architecture and code paths: - Remove Super BF16 tests (test_auto_dtype_4gpus, test_bf16_trtllm_gen_moe_backend, test_bf16_4gpu_mtp_ar) - Remove Super test_nvfp4_8gpus; 8-GPU MoE backend coverage is represented by the Ultra variants - Remove Ultra test_nvfp4_4gpu_mtp_ar (duplicate of the Super case) and drop the B300 waive of the Super case (nvbugs/6336990) - Use context manager for LLM in MTP acceptance-rate tests to ensure proper shutdown - Rename Super block_reuse ids: TEP4_ADP -> DEP4_MTP_OFF, TEP4_ADP_MTP -> DEP4_MTP_ON - Move to post-merge: Super fp8_4gpus (all combos), 8gpus_mtp_custom_op, parallelism[TP4_PP2/TP8_PP1], online_eplb[TRTLLM], block_reuse[TEP4/DEP4_MTP_OFF]; Ultra online_eplb[CUTEDSL], parallelism[ADP2_PP2] Pre-merge L0 cases reduced from 22 to 7 while keeping one representative per functional dimension (MoE backends, MTP accuracy and acceptance rate, block reuse with TEP/DEP mappings, Hopper W4A16); the QA list retains broader coverage. Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR reorganizes Nemotron V3 Super/Ultra integration tests: several test methods are removed, NVFP4 parametrization ids are renamed, MTP acceptance-rate tests are refactored to use LLM as a context manager, and corresponding QA test lists, test-db matrices (B200/H100/GB200), and a waiver entry are updated to match. ChangesNemotron V3 test suite reorganization
Estimated code review effort: 2 (Simple) | ~12 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #58245 [ run ] triggered by Bot. Commit: |
|
PR_Github #58245 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #58339 [ run ] triggered by Bot. Commit: |
|
PR_Github #58339 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #58409 [ run ] triggered by Bot. Commit: |
|
PR_Github #58409 [ run ] completed with state |
Consolidate Nemotron V3 Super/Ultra accuracy tests since both models share the same NemotronH architecture and code paths:
Pre-merge L0 cases reduced from 22 to 7 while keeping one representative per functional dimension (MoE backends, MTP accuracy and acceptance rate, block reuse with TEP/DEP mappings, Hopper W4A16); the QA list retains broader coverage.
Summary by CodeRabbit
Bug Fixes
Tests
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.