[https://nvbugs/6428063][fix] Include use_host_stop_criteria in the PP ring-broadcast payload (sender uses…

[trtllm-agent]

Summary

• Root cause: PR [None][perf] Move greedy stop checks to host #15920's new SampleStateTorch.use_host_stop_criteria flag was set only on the last PP rank; non-last PP ranks received sample_state.host with finish_reasons=None but kept the local default False, hitting the process_draft_tokens branch which indexed an empty list.
• Fix: Include use_host_stop_criteria in the PP ring-broadcast payload (sender uses getattr default False; receiver assigns via hasattr guard) so all PP ranks agree on the sampler fast-path decision; also removed the corresponding waiver line.
• Automated fix generated by repair-bot

Test plan

• Verify fix on the same GPU type as the original failure
• Check for regressions in related tests

Links

• Bug: https://nvbugs/6428063

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of pipeline-stage message exchange so additional stop-criteria state is preserved during asynchronous processing.
  • Reduced the chance of inconsistent generation behavior across stages by keeping sender and receiver state in sync.

• Tests

  • Removed an outdated test waiver from the integration test list.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0582325d-513e-4312-8278-f062be4752c7

📥 Commits

Reviewing files that changed from the base of the PR and between 5ce293f and fbefd41.

📒 Files selected for processing (2)

• tensorrt_llm/_torch/pyexecutor/py_executor.py
• tests/integration/test_lists/waives.txt

💤 Files with no reviewable changes (1)

• tests/integration/test_lists/waives.txt

---

📝 Walkthrough

Walkthrough

This PR modifies the PP ring broadcast protocol in py_executor.py to send and receive an additional use_host_stop_criteria boolean alongside sample_state, and removes an obsolete test waiver entry from waives.txt.

Changes

Ring Broadcast Protocol Update

Layer / File(s)	Summary
Propagate use_host_stop_criteria in ring broadcast tensorrt_llm/_torch/pyexecutor/py_executor.py	Receive-side unpacks an additional use_host_stop_criteria from recv_object and assigns it to sample_state; send-side includes getattr(sample_state, "use_host_stop_criteria", False) when calling isend_object.

Test Waiver Cleanup

Layer / File(s)	Summary
Remove obsolete waiver tests/integration/test_lists/waives.txt	Removes the SKIP entry for test_nvfp4_4gpus (CUTLASS, mtp_nextn=0, pp4, fp8kv=True, torch_compile=True) referencing nvbugs/6428063.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• NVIDIA/TensorRT-LLM#16097: Also modifies tests/integration/test_lists/waives.txt, updating SKIP entries in the same file.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is specific and matches the main fix to the PP ring-broadcast payload.
Description check	✅ Passed	The description includes summary, test plan, and bug link, but omits the PR Checklist section.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}