[https://nvbugs/6422299][fix] Setup dependency for Cosmos3 nano t2v LPIPS test - #16139
Conversation
Signed-off-by: yibinl-nvidia <109242046+yibinl-nvidia@users.noreply.github.com>
Signed-off-by: yibinl-nvidia <109242046+yibinl-nvidia@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughAdds the ChangesVisualGen Test Fixture and Waiver Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run |
|
PR_Github #58320 [ run ] triggered by Bot. Commit: |
|
PR_Github #58320 [ run ] completed with state |
Description
Fix the Cosmos3-Nano T2V LPIPS test dependency wiring so the
_visual_gen_depsfixture runs before the test writes an MP4 file.The test uses
_save_lpips_video_mp4(), which intentionally fails when ffmpeg is unavailable to avoid comparing codec artifacts against the golden video. Without this fixture, isolated or sharded runs can skip the ffmpeg install path and fail before LPIPS is evaluated.Testing
git diff --checkpython3 -m py_compile tests/integration/defs/examples/visual_gen/test_visual_gen.pySummary by CodeRabbit