Skip to content

[https://nvbugs/6422299][fix] Setup dependency for Cosmos3 nano t2v LPIPS test - #16139

Merged
yibinl-nvidia merged 2 commits into
NVIDIA:mainfrom
yibinl-nvidia:fix-visual-gen-lpips-ffmpeg-deps
Jul 9, 2026
Merged

[https://nvbugs/6422299][fix] Setup dependency for Cosmos3 nano t2v LPIPS test#16139
yibinl-nvidia merged 2 commits into
NVIDIA:mainfrom
yibinl-nvidia:fix-visual-gen-lpips-ffmpeg-deps

Conversation

@yibinl-nvidia

@yibinl-nvidia yibinl-nvidia commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix the Cosmos3-Nano T2V LPIPS test dependency wiring so the _visual_gen_deps fixture runs before the test writes an MP4 file.

The test uses _save_lpips_video_mp4(), which intentionally fails when ffmpeg is unavailable to avoid comparing codec artifacts against the golden video. Without this fixture, isolated or sharded runs can skip the ffmpeg install path and fail before LPIPS is evaluated.

Testing

  • git diff --check
  • python3 -m py_compile tests/integration/defs/examples/visual_gen/test_visual_gen.py

Summary by CodeRabbit

  • Tests
    • Updated a visual generation integration test to use the shared VisualGen setup fixture.
    • Adjusted a waived test entry to match the current visual generation variant under test.

Signed-off-by: yibinl-nvidia <109242046+yibinl-nvidia@users.noreply.github.com>
@yibinl-nvidia yibinl-nvidia changed the title test: require visual gen deps for Cosmos3 LPIPS [https://nvbugs/6422299][fix] require visual gen deps for Cosmos3 LPIPS Jul 8, 2026
@yibinl-nvidia yibinl-nvidia changed the title [https://nvbugs/6422299][fix] require visual gen deps for Cosmos3 LPIPS [https://nvbugs/6422299][fix] Setup dependency for Cosmos3 nano t2v LPIPS test Jul 8, 2026
Signed-off-by: yibinl-nvidia <109242046+yibinl-nvidia@users.noreply.github.com>
@yibinl-nvidia
yibinl-nvidia marked this pull request as ready for review July 8, 2026 20:55
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8a09847f-3926-4540-ab3e-55039fe4d50a

📥 Commits

Reviewing files that changed from the base of the PR and between 5ce293f and f87578b.

📒 Files selected for processing (2)
  • tests/integration/defs/examples/visual_gen/test_visual_gen.py
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Adds the _visual_gen_deps fixture parameter to test_cosmos3_nano_t2v_lpips_against_golden and replaces the waived t2v entry with a t2i entry (different nvbugs link) for the same test pattern in waives.txt.

Changes

VisualGen Test Fixture and Waiver Update

Layer / File(s) Summary
Test fixture and waiver update
tests/integration/defs/examples/visual_gen/test_visual_gen.py, tests/integration/test_lists/waives.txt
Adds _visual_gen_deps fixture parameter to the golden LPIPS test and updates the waiver entry from the t2v to t2i variant with a different nvbugs link.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: dongxuy04, pcastonguay

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title uses a valid NVBugs ticket, fix type, and clearly summarizes the Cosmos3 Nano T2V LPIPS dependency fix.
Description check ✅ Passed The description covers the issue, solution, and testing, but it omits the PR checklist section from the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@yibinl-nvidia

Copy link
Copy Markdown
Collaborator Author

/bot help

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@yibinl-nvidia
yibinl-nvidia requested a review from a team July 8, 2026 23:16
@yibinl-nvidia

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58320 [ run ] triggered by Bot. Commit: f87578b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58320 [ run ] completed with state SUCCESS. Commit: f87578b
/LLM/main/L0_MergeRequest_PR pipeline #46951 completed with status: 'SUCCESS'

CI Report

Link to invocation

@yibinl-nvidia
yibinl-nvidia requested review from a team and EmmaQiaoCh and removed request for a team July 9, 2026 02:24
@yibinl-nvidia
yibinl-nvidia merged commit 3f526cf into NVIDIA:main Jul 9, 2026
11 checks passed
@yibinl-nvidia
yibinl-nvidia deleted the fix-visual-gen-lpips-ffmpeg-deps branch July 10, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants