[https://nvbugs/6428087][fix] Extend the PP send payload with the flag (backward-compatible 2/3-tuple… - #16145
Open
trtllm-agent wants to merge 1 commit into
Open
[https://nvbugs/6428087][fix] Extend the PP send payload with the flag (backward-compatible 2/3-tuple…#16145trtllm-agent wants to merge 1 commit into
trtllm-agent wants to merge 1 commit into
Conversation
The greedy host stop-criteria optimization (PR NVIDIA#15920) added a per-batch flag `use_host_stop_criteria` on `SampleStateTorch` that gates whether `update_requests` uses the host fast path or calls `process_draft_tokens`. In the PP execution loop, `SampleStateTorch` is constructed on non-last PP ranks via `_forward_step_inter_pp` without setting this flag, and only `sample_state.host` and per-request result diffs are shipped via ring send/recv from the last PP rank. Consequently, when the last PP rank determined `use_host_stop_criteria=True` and therefore skipped writing finish_reasons, earlier PP ranks still saw the default False and entered `process_draft_tokens`, which then indexed an empty finish_reasons list and raised `IndexError: list index out of range` from `finish_if_reason`. Extend the PP send payload with the flag (backward-compatible: recv accepts both 2- and 3-tuple payloads, and send only appends the flag when the sampler exposes the attribute) so that all ranks pick the same branch. Also remove the associated waiver. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR extends the PP (pipeline parallelism) ring broadcast for ChangesSample State Broadcast Fix
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Links
Summary by CodeRabbit
Bug Fixes
Tests