Skip to content

[https://nvbugs/6379333] [chore] Unwaive test cases - #16180

Merged
kaiyux merged 1 commit into
NVIDIA:mainfrom
kaiyux:user/kaiyu/bug_6379333
Jul 13, 2026
Merged

[https://nvbugs/6379333] [chore] Unwaive test cases#16180
kaiyux merged 1 commit into
NVIDIA:mainfrom
kaiyux:user/kaiyu/bug_6379333

Conversation

@kaiyux

@kaiyux kaiyux commented Jul 9, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Tests
    • Updated integration test waivers for DeepSeekR1 fp8 blockscale cases to reflect the current skipped throughput checks and remove outdated multi-GPU entries.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@kaiyux
kaiyux marked this pull request as draft July 9, 2026 06:42
@kaiyux

kaiyux commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

/bot help

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated test waiver entries for DeepSeekR1 fp8 blockscale test cases in waives.txt, replacing throughput-based skip entries with throughput_mtp and throughput_mtp_trtllm skips referencing nvbugs 6428101 and 6426868, and removing related multi-GPU fp8 entries.

Changes

Waiver List Update

Layer / File(s) Summary
Update fp8 blockscale skip entries
tests/integration/test_lists/waives.txt
Replaces DeepSeekR1 test_fp8_blockscale throughput waivers with throughput_mtp and throughput_mtp_trtllm skips (nvbugs 6428101, 6426868), removing related multi-GPU fp8 entries.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#16109: Both PRs modify waives.txt around DeepSeekR1 fp8 blockscale/throughput_mtp waiver entries for the same cases.
  • NVIDIA/TensorRT-LLM#16146: Both PRs add/remove SKIP waivers for DeepSeek fp8 block-scale test variants tied to nvbugs 6428101/6426868.
  • NVIDIA/TensorRT-LLM#16093: Both PRs update waives.txt with DeepSeek blockscale/fp8-related throughput waivers.

Suggested reviewers: mzweilz

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly just the template and checklist, with no actual issue summary or test coverage details. Add a short Description explaining the problem and fix, plus Test Coverage with the relevant tests run or planned.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the PR's main intent and uses the required ticket and type format.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@kaiyux

kaiyux commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

/bot run --only-multi-gpu-test --disable-fail-fast

@kaiyux kaiyux changed the title Unwaive test cases for https://nvbugs/6379333 [https://nvbugs/6379333] [chore] Unwaive test cases for https://nvbugs/6379333 Jul 9, 2026
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58404 [ run ] triggered by Bot. Commit: c9793c7 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58404 [ run ] completed with state SUCCESS. Commit: c9793c7
/LLM/main/L0_MergeRequest_PR pipeline #47023 (Partly Tested) completed with status: 'ABORTED'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@kaiyux kaiyux changed the title [https://nvbugs/6379333] [chore] Unwaive test cases for https://nvbugs/6379333 [https://nvbugs/6379333] [chore] Unwaive test cases Jul 9, 2026
Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
@kaiyux
kaiyux force-pushed the user/kaiyu/bug_6379333 branch from c9793c7 to 04bbb34 Compare July 11, 2026 01:39
@kaiyux

kaiyux commented Jul 11, 2026

Copy link
Copy Markdown
Member Author

/bot run --only-multi-gpu-test --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58728 [ run ] triggered by Bot. Commit: 04bbb34 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58728 [ run ] completed with state FAILURE. Commit: 04bbb34
/LLM/main/L0_MergeRequest_PR pipeline #47311 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@kaiyux
kaiyux marked this pull request as ready for review July 13, 2026 09:12
@kaiyux

kaiyux commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

The test cases are passing in the above pipeline

image

@kaiyux

kaiyux commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

/bot skip --comment "unwaive test"

@kaiyux
kaiyux enabled auto-merge (squash) July 13, 2026 09:16
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58944 [ skip ] triggered by Bot. Commit: 04bbb34 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58944 [ skip ] completed with state SUCCESS. Commit: 04bbb34
Skipping testing for commit 04bbb34

Link to invocation

@kaiyux
kaiyux merged commit 01291f9 into NVIDIA:main Jul 13, 2026
10 checks passed
@kaiyux
kaiyux deleted the user/kaiyu/bug_6379333 branch July 13, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants