[None][chore] Remove pre-installed opencv by tburt-nv · Pull Request #16206 · NVIDIA/TensorRT-LLM

tburt-nv · 2026-07-09T21:16:10Z

Description

Removes pre-installed opencv from the container images, making it an optional dependency.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

Documentation
- Added guidance for video-input use cases, including how to install the extra package needed for decoding videos.
- Clarified that image-only and text-only workflows do not require this optional dependency.
Chores
- Updated setup and installation flows to account for the optional video-decoding package in automated environments.

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>

tburt-nv · 2026-07-09T21:16:31Z

/bot run --stage-list "Build-Docker-Images"

coderabbitai · 2026-07-09T21:20:35Z

📝 Walkthrough

Walkthrough

OpenCV is removed from default Docker and requirements installation, added explicitly to selected Jenkins and Slurm environments, and documented as an optional dependency for video input.

Changes

Optional OpenCV installation

Layer / File(s)	Summary
Remove OpenCV from default installation `docker/Dockerfile.multi`, `docker/common/install.sh`, `requirements.txt`	The development image, shared installer, and default requirements no longer install or process OpenCV.
Install OpenCV in test environments `jenkins/L0_Test.groovy`, `jenkins/scripts/slurm_install.sh`, `jenkins/scripts/perf/local/slurm_install.sh`	Selected Jenkins and Slurm setup paths explicitly install `opencv-python-headless`.
Document video dependency `docs/source/features/multi-modality.md`	Documentation identifies OpenCV as optional for video input and provides the installation command.

Estimated code review effort: 2 (Simple) | ~15 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title is concise, matches the main change, and uses the repository's required ticket/type format.
Description check	✅ Passed	The PR description mostly follows the template and states the change, but the Test Coverage section is empty.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docker/Dockerfile.multi`:
- Around line 51-52: The Dockerfile.multi modification is missing the required
NVIDIA copyright header. Add the standard NVIDIA copyright notice at the top of
the file, using the year from the latest meaningful change, and ensure the
header is placed before the existing install command block in the
Dockerfile.multi content.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 4bc2f248-66be-4307-8793-5ecb59eade8d

📥 Commits

Reviewing files that changed from the base of the PR and between 8e7b98c and 7dcde4c.

📒 Files selected for processing (7)

docker/Dockerfile.multi
docker/common/install.sh
docs/source/features/multi-modality.md
jenkins/L0_Test.groovy
jenkins/scripts/perf/local/slurm_install.sh
jenkins/scripts/slurm_install.sh
requirements.txt

💤 Files with no reviewable changes (2)

requirements.txt
docker/common/install.sh

tensorrt-cicd · 2026-07-09T21:22:21Z

PR_Github #58513 [ run ] triggered by Bot. Commit: 7dcde4c Link to invocation

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>

schetlur-nv

lgtm

tensorrt-cicd · 2026-07-10T01:11:26Z

PR_Github #58513 [ run ] completed with state FAILURE. Commit: 7dcde4c
/LLM/main/L0_MergeRequest_PR pipeline #47119 (Partly Tested) completed with status: 'ABORTED'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

chzblych · 2026-07-10T06:17:36Z

/bot run --disable-fail-fast

tensorrt-cicd · 2026-07-10T06:24:19Z

PR_Github #58616 [ run ] triggered by Bot. Commit: 88c8d75 Link to invocation

tburt-nv · 2026-07-10T16:50:51Z

/bot run --disable-fail-fast --only-multi-gpu-test

tensorrt-cicd · 2026-07-10T16:57:06Z

PR_Github #58684 [ run ] triggered by Bot. Commit: 88c8d75 Link to invocation

tensorrt-cicd · 2026-07-10T17:02:16Z

PR_Github #58616 [ run ] completed with state ABORTED. Commit: 88c8d75

Link to invocation

tburt-nv · 2026-07-10T17:41:13Z

If these two pipelines pass, we can merge:

tburt-nv · 2026-07-10T19:36:46Z

/bot skip --comment "all stages pass except DGX_B200-8_GPUs-PyTorch* which contains no relevant tests"

tensorrt-cicd · 2026-07-10T19:42:45Z

PR_Github #58695 [ ] completed with state FAILURE. Commit: 88c8d75
Not allowed on merged PR

Link to invocation

tensorrt-cicd · 2026-07-10T20:33:00Z

PR_Github #58684 [ run ] completed with state SUCCESS. Commit: 88c8d75
/LLM/main/L0_MergeRequest_PR pipeline #47270 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

…m images (OPS-7625) Upstream TRT-LLM made cv2 an optional video extra (NVIDIA/TensorRT-LLM#16206) and no longer preinstalls it on main; its imports were already function-local in 1.3.x, so nothing in the image needs it at import time. Align the trtllm runtime images with that: uninstall the package (via the system interpreter -- with VIRTUAL_ENV set, plain pip targets the venv and exits 0 without touching the system-site install) and mirror the removal in the pre_runtime whiteout, since the squash COPY cannot represent deletions. Build fails if cv2 survives either stage, and a dependencies test guards against a base-image bump reintroducing it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Dmitry Tokarev <dtokarev@nvidia.com>

tburt-nv added 3 commits July 9, 2026 13:56

stop installing opencv

f138cd9

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>

install opencv in CI

c65bf30

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>

update doc

7dcde4c

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>

tburt-nv requested a review from a team July 9, 2026 21:16

tburt-nv requested review from a team as code owners July 9, 2026 21:16

tburt-nv requested review from a team, 2ez4bz, arysef, aswinvisva, mlefeb01, niukuo, nv-guomingz and yiqingy0 July 9, 2026 21:16

github-actions Bot assigned tburt-nv Jul 9, 2026

coderabbitai Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread docker/Dockerfile.multi

2ez4bz approved these changes Jul 9, 2026

View reviewed changes

Comment thread docker/Dockerfile.multi

Comment thread docs/source/features/multi-modality.md

clarify missing lazy load error message

8013934

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>

venkywonka approved these changes Jul 9, 2026

View reviewed changes

schetlur-nv approved these changes Jul 10, 2026

View reviewed changes

chzblych approved these changes Jul 10, 2026

View reviewed changes

Comment thread docker/Dockerfile.multi

chzblych added 3 commits July 10, 2026 12:26

Update current_image_tags.properties

792022c

Merge branch 'main' into user/tburt/remove_opencv

a2753f1

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

Update Docker image tags in current_image_tags.properties

88c8d75

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>

NVIDIA deleted a comment from tensorrt-cicd Jul 10, 2026

mikeiovine approved these changes Jul 10, 2026

View reviewed changes

tburt-nv enabled auto-merge (squash) July 10, 2026 19:36

tburt-nv disabled auto-merge July 10, 2026 19:38

tburt-nv merged commit e523b43 into NVIDIA:main Jul 10, 2026
8 of 9 checks passed

trtllm-agent mentioned this pull request Jul 13, 2026

[https://nvbugs/6437341][fix] Port sibling fix 38db241414 verbatim (shutil.which short-circuit +… #16306

Closed

2 tasks

dmitry-tokarev-nv mentioned this pull request Jul 13, 2026

chore(container): remove opencv-python-headless from TRT-LLM images (OPS-7625) ai-dynamo/dynamo#11607

Open

ishovkun mentioned this pull request Jul 20, 2026

[None][feat] Cosmos3 video-to-video (V2V) generation #16155

Open

1 task

Uh oh!

Conversation

tburt-nv commented Jul 9, 2026 • edited by chzblych Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Coverage

PR Checklist

GitHub Bot Help

Summary by CodeRabbit

Uh oh!

tburt-nv commented Jul 9, 2026

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tensorrt-cicd commented Jul 9, 2026

Uh oh!

Uh oh!

Uh oh!

schetlur-nv left a comment

Choose a reason for hiding this comment

Uh oh!

tensorrt-cicd commented Jul 10, 2026

Uh oh!

Uh oh!

chzblych commented Jul 10, 2026

Uh oh!

tensorrt-cicd commented Jul 10, 2026

Uh oh!

tburt-nv commented Jul 10, 2026

Uh oh!

tensorrt-cicd commented Jul 10, 2026

Uh oh!

tensorrt-cicd commented Jul 10, 2026

Uh oh!

tburt-nv commented Jul 10, 2026

Uh oh!

tburt-nv commented Jul 10, 2026

Uh oh!

Uh oh!

tensorrt-cicd commented Jul 10, 2026

Uh oh!

tensorrt-cicd commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tburt-nv commented Jul 9, 2026 •

edited by chzblych

Loading

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading