Skip to content

[https://nvbugs/6437410][chore] Waive a failed test in pre-merge CI - #16308

Merged
shuyixiong merged 1 commit into
NVIDIA:mainfrom
shuyixiong:waive_ray_test
Jul 13, 2026
Merged

[https://nvbugs/6437410][chore] Waive a failed test in pre-merge CI#16308
shuyixiong merged 1 commit into
NVIDIA:mainfrom
shuyixiong:waive_ray_test

Conversation

@shuyixiong

@shuyixiong shuyixiong commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Added a test waiver to skip a multi-GPU weight-update scenario associated with known issue 6437410.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: shuyixiong <219646547+shuyixiong@users.noreply.github.com>
@shuyixiong

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive a test"

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c6a04d92-d5f2-4134-8908-778db52b9b4e

📥 Commits

Reviewing files that changed from the base of the PR and between 5088a4d and 453354c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Adds a waiver entry that skips the part4 multi-GPU Ray orchestrator test and links it to nvbugs/6437410.

Changes

Test waiver

Layer / File(s) Summary
Add multi-GPU test waiver
tests/integration/test_lists/waives.txt
Adds a SKIP waiver for the part4 invocation of test_llm_update_weights_multi_gpu.py, referencing nvbugs/6437410.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: crazydemo, larryxfly, stanleysun639, xinhe-nv, emmaqiaoch

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description keeps the template placeholders and does not explain the issue, solution, or test coverage. Fill in the Description and Test Coverage sections with the problem, the waiver change, and any relevant verification details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the repository template and accurately describes waiving a failed CI test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58920 [ skip ] triggered by Bot. Commit: 453354c Link to invocation

@Superjomn Superjomn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58920 [ skip ] completed with state SUCCESS. Commit: 453354c
Skipping testing for commit 453354c

Link to invocation

@shuyixiong
shuyixiong merged commit 53d2bde into NVIDIA:main Jul 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants