[https://nvbugs/6445322][fix] Restore the pre-#16108 baseline - accuracy: 56.667 alongside the existing… - #16310
Merged
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a 56.667 accuracy reference for ChangesMMMU reference data
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/defs/accuracy/references/mmmu.yaml`:
- Line 17: Add the standard SPDX copyright and license comment header to
mmmu.yaml, matching the format and values used by neighboring accuracy reference
YAML files, before the existing accuracy entry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 83f41425-04fc-4af7-8ce5-4bbff913c7b7
📒 Files selected for processing (1)
tests/integration/defs/accuracy/references/mmmu.yaml
…26B-A4B-it PR NVIDIA#16108 replaced the plain unquantized entry for google/gemma-4-26B-A4B-it with only an NVFP4 entry, which broke TestGemma4MoE::test_bf16: the autodeploy bf16 test looks up the model with no quant (defaults: dtype='auto', quant_algo=None, kv_cache_quant_algo=None, ...) and no reference row matched, raising ValueError: Not registered specs. Add the pre-NVIDIA#16108 bf16 baseline (56.667) back alongside the NVFP4 entry so both TestGemma4MoE::test_bf16 (H100 autodeploy, bf16) and the new PyTorch NVFP4 test resolve their thresholds. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
trtllm-agent
force-pushed
the
repair-bot-bug6445322
branch
from
July 13, 2026 09:36
0cc697f to
e5350dc
Compare
2ez4bz
approved these changes
Jul 13, 2026
Collaborator
|
/bot run |
Collaborator
|
PR_Github #58999 [ run ] triggered by Bot. Commit: |
2ez4bz
enabled auto-merge (squash)
July 13, 2026 16:26
Collaborator
|
PR_Github #58999 [ run ] completed with state |
LarryXFly
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google/gemma-4-26B-A4B-itintests/integration/defs/accuracy/references/mmmu.yamlwith only an NVFP4 entry, so the autodeploy bf16 test's default acc_specs matched no row and raisedValueError: Not registered specs.- accuracy: 56.667alongside the existing NVFP4 entry (same coexistence pattern used for gemma-3-27b-it / gemma-3-12b-it in the same file).Test plan
Links
Summary by CodeRabbit