[https://nvbugs/6442073][fix] Lower free_gpu_memory_fraction from 0.6 → 0.4 (aligning with sibling… - #16315
[https://nvbugs/6442073][fix] Lower free_gpu_memory_fraction from 0.6 → 0.4 (aligning with sibling…#16315trtllm-agent wants to merge 1 commit into
free_gpu_memory_fraction from 0.6 → 0.4 (aligning with sibling…#16315Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Qwen3 multimodal accuracy test now uses a lower KV-cache GPU memory fraction, and its H100 and H20 ChangesMultimodal accuracy test updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
not the real fix, waiting for further bug comments. |
…fix H100/H20 OOM TestQwen3_5_35B_A3B_VL::test_auto_dtype OOMs mid-inference on 80-93GB GPUs. Weights (~65GB) + non-torch overhead (~8GB) + KV cache sized at 0.6 of remaining free (~13.5GB) + CUDA-graph replay buffers for 32 batch sizes + attention workspaces that grow with real batch/token counts push actual peak past the profiled peak, and cudaMalloc for the next attention scratch buffer (AttentionOp::reserveSemaphoreArray) fails. Every sibling large-MoE MMMU test in the same file already uses free_gpu_memory_fraction=0.4 (TestMistralLarge3_675B, TestQwen3VL_MOE, TestGemma3_27BInstruct). Aligning TestQwen3_5_35B_A3B_VL with them frees ~4.5 GiB of headroom (KV cache drops from 13.51 GiB to 9.01 GiB on the 93 GiB H20 node) and the test now passes end-to-end. Also remove the H100 and H20 waives added for this bug now that the test passes. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
47ace75 to
b13dadf
Compare
|
the bug might not be caused by wrong memory configuration, please deep-diving into the architectures to see whether we can reproduce that, and which components consumed unusual memory footprint. After that, please fix the real issue rather than simplely tune the memory footprint config. |
Summary
TestQwen3_5_35B_A3B_VL.kv_cache_configusesfree_gpu_memory_fraction=0.6— with ~65 GB weights + ~8 GB non-torch overhead + 32-batch CUDA-graph replay buffers, real inference peak exceeds the profiled peak on 80–93 GB devices, and cudaMalloc for the next attention scratch buffer fails.free_gpu_memory_fractionfrom 0.6 → 0.4 (aligning with sibling large-MoE VLM tests) and remove both H100/H20 waivers now that the test passes. KV cache drops 13.51 → 9.01 GiB, freeing ~4.5 GiB headroom.Test plan
Links
Summary by CodeRabbit