[TRTLLM-13948][feat] DeepSeek V3 Lite TranceiverV2 migration - #16390
[TRTLLM-13948][feat] DeepSeek V3 Lite TranceiverV2 migration#16390asfiyab-nvidia wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (18)
📝 WalkthroughWalkthroughThe PR updates DeepSeek disaggregated serving configurations to use the NIXL cache backend with an explicit Python transceiver runtime, including the corresponding NIXL accuracy test configuration. ChangesNIXL Python runtime configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…rf-sanity test Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
1d2e2e6 to
d93a956
Compare
|
/bot run --disable-fail-fast --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, DGX_B200-8_GPUs-PyTorch-1, |
|
PR_Github #59327 [ run ] triggered by Bot. Commit: |
|
PR_Github #59327 [ run ] completed with state |
|
/bot run --disable-reuse-test --disable-fail-fast --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, |
|
PR_Github #59489 [ run ] triggered by Bot. Commit: |
|
PR_Github #59489 [ run ] completed with state
|
|
/bot run --disable-reuse-test --disable-fail-fast --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1, |
|
PR_Github #59531 [ run ] triggered by Bot. Commit: |
|
PR_Github #59531 [ run ] completed with state
|
There was a problem hiding this comment.
This config is shared by two tests, and hardcoding the backend here silently breaks one of them.
test_disaggregated_deepseek_v3_lite_fp8_ucx_tp1_single_gpu selects UCX by setting TRTLLM_USE_UCX_KVCACHE=1 and reuses this same config (config_map["deepseek_v3_lite_fp8_tp1"]). That env var is only consulted when the backend is DEFAULT — CacheTransceiverConfig._resolve_default_backend() returns early for any explicit backend:
if self.backend != "DEFAULT":
return self.backend, None
After this change the env var is ignored with no warning, so that test runs NIXL + Python instead of UCX. It still passes, and it is now byte-for-byte identical to test_disaggregated_deepseek_v3_lite_fp8_tp1_single_gpu. We'd lose UCX coverage at tp1/single-GPU (the case is enabled in l0_h100.yml:184) and burn a pre-merge slot on a duplicate.
Suggest adding a dedicated disagg_config_ctxtp1_gentp1_deepseek_v3_lite_ucx.yaml with backend: UCX, registering it as deepseek_v3_lite_fp8_tp1_ucx in config_map, and pointing the UCX test at it (the env var can then be dropped).
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.