Skip to content

[None][fix] fix missing torch_dtype_to_binding - #16401

Merged
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:main-fix-ci
Jul 15, 2026
Merged

[None][fix] fix missing torch_dtype_to_binding#16401
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:main-fix-ci

Conversation

@bo-nv

@bo-nv bo-nv commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Updated internal imports without changing user-visible functionality or behavior.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Bo Deng <deemod@nvidia.com>
@bo-nv
bo-nv requested a review from VALLIS-NERIA July 15, 2026 04:57
@bo-nv
bo-nv requested a review from a team as a code owner July 15, 2026 04:57
@bo-nv
bo-nv requested a review from nvpohanh July 15, 2026 04:57
@bo-nv

bo-nv commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Just add missing module"

@bo-nv
bo-nv enabled auto-merge (squash) July 15, 2026 04:58
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9ebcf3ae-b5cf-4c10-9abc-2a3464c450a8

📥 Commits

Reviewing files that changed from the base of the PR and between e322472 and 294c20d.

📒 Files selected for processing (1)
  • tensorrt_llm/_torch/pyexecutor/mamba_cache_manager.py

📝 Walkthrough

Walkthrough

The Mamba cache manager’s _utils import is reformatted into a multi-line statement and now imports torch_dtype_to_binding.

Changes

Mamba cache manager imports

Layer / File(s) Summary
Update _utils imports
tensorrt_llm/_torch/pyexecutor/mamba_cache_manager.py
The import list is reformatted and adds torch_dtype_to_binding. No runtime logic changes are included.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: nvpohanh, vallis-neria

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is still the template and lacks the required issue, solution, and test coverage details. Add a short Description explaining the bug and fix, plus Test Coverage listing the tests run or needed for this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the change: fixing missing torch_dtype_to_binding support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59364 [ skip ] triggered by Bot. Commit: 294c20d Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59364 [ skip ] completed with state SUCCESS. Commit: 294c20d
Skipping testing for commit 294c20d

Link to invocation

@bo-nv
bo-nv merged commit bcf5a20 into NVIDIA:main Jul 15, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants