[https://nvbugs/6433809][test] Guard Cutlass MoE TorchBind schema arity - #16405
[https://nvbugs/6433809][test] Guard Cutlass MoE TorchBind schema arity#16405nv-yna wants to merge 1 commit into
Conversation
Signed-off-by: Yuewei Na <nv-yna@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdded a CUDA/TensorRT-LLM smoke test that compares ChangesMoE schema validation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Non-blocking, out of scope for this PR: the 43-arg |
Description
NVBug 6433809 exposed a Python/TorchBind ABI regression in the Cutlass MoE path: the rc19/rc20 Python caller supplied 36 positional arguments while the loaded
FusedMoeRunner.run_moeschema required 43, so TP4/EP4 WideEP initialization failed at the first omitted argument (_37).Main already contains the production correction from #15330. This PR adds the missing regression guard:
CutlassMoEOp.compute_moePython call path with a capture runner;FusedMoeRunner.run_moeschema; andThis catches future C++ schema extensions that are not reflected in the Python caller without requiring a heavyweight model load.
Test Coverage
supplied 36 arguments ... schema requires 43.1 passed._37errors and zero failed executor ranks, then registereddynamo.prefill.generate.pre-commit run --files tests/unittest/_torch/modules/moe/test_cutlass_moe_op_smoke.py tests/integration/test_lists/test-db/l0_h100.yml— passed all applicable hooks.git diff --check— passed.The workstation's standalone pytest environment is missing
nvtx, so local collection stops in the repository-wideconftestbefore reaching this test. The exact-image pytest A/B result above exercises the test itself; CI supplies the built extension and runtime dependencies.PR Checklist
Summary by CodeRabbit