[None][infra] Waive 1 failed cases for main in pre-merge 47916 - #16434
[None][infra] Waive 1 failed cases for main in pre-merge 47916#16434trtllm-agent wants to merge 1 commit into
Conversation
Bug(s): 6461799 Requested by: @MrGeva Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
📝 WalkthroughWalkthroughAdds a SKIP waiver for a specific multigpu auto-deploy smoke test invocation, referencing nvbugs/6461799. ChangesTest waiver update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 463: Add the repository-standard NVIDIA copyright header to the modified
waives.txt file, using the current required copyright year for modified files.
Preserve the existing test entry unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 512d1bef-c909-40e9-8aaa-6379df10dda8
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
| unittest/auto_deploy/multigpu/custom_ops/test_ad_dist_strategies.py::test_allreduce_strategies[AUTO] SKIP (https://nvbugs/6403920) | ||
| unittest/auto_deploy/multigpu/custom_ops/test_ad_dist_strategies.py::test_allreduce_strategies[NCCL] SKIP (https://nvbugs/6403920) | ||
| unittest/auto_deploy/multigpu/custom_ops/test_ad_dist_strategies.py::test_allreduce_strategies[SYMM_MEM] SKIP (https://nvbugs/6403920) | ||
| unittest/auto_deploy/multigpu/smoke/test_ad_build_small_multi.py::test_build_ad[meta-llama/Meta-Llama-3.1-8B-Instruct-llm_extra_args0-1] SKIP (https://nvbugs/6461799) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the required NVIDIA copyright header.
This modified file has no NVIDIA copyright header. Add the repository-standard header and update its copyright year as required for modified files.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tests/integration/test_lists/waives.txt` at line 463, Add the
repository-standard NVIDIA copyright header to the modified waives.txt file,
using the current required copyright year for modified files. Preserve the
existing test entry unchanged.
Source: Coding guidelines
|
/bot skip --comment "waive only" |
|
PR_Github #59470 [ skip ] triggered by Bot. Commit: |
|
PR_Github #59470 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @MrGeva)
Target branch:
mainBug(s): 6461799
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit