Skip to content

[None][test] Consolidate test coverage for helix - #16570

Merged
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/lower-helix-coverage
Jul 19, 2026
Merged

[None][test] Consolidate test coverage for helix#16570
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/lower-helix-coverage

Conversation

@brb-nv

@brb-nv brb-nv commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Description

This MR consolidates test coverage for helix parallelism. We'll have a follow-up MR that adds more unit tests to reinforce coverage that remains.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Tests
    • Streamlined disaggregated-serving accuracy coverage by focusing on selected Helix configurations.
    • Removed an outdated DeepSeek experimental Helix accuracy test.
    • Limited one DeepSeek test to short prompts.
    • Updated QA and hardware test matrices to reflect the revised coverage.
    • Refreshed waived test cases accordingly.

Signed-off-by: Balaram Buddharaju <169953907+brb-nv@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3ce6d2da-01a9-48f8-958a-67d58167aa08

📥 Commits

Reviewing files that changed from the base of the PR and between 634abb8 and eabd20f.

📒 Files selected for processing (5)
  • tests/integration/defs/accuracy/test_disaggregated_serving.py
  • tests/integration/defs/disaggregated/test_disaggregated.py
  • tests/integration/test_lists/qa/llm_function_core.txt
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (3)
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml
  • tests/integration/test_lists/qa/llm_function_core.txt
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Disaggregated serving tests now cover fewer Helix parallelism and communication combinations, remove the DeepSeek V32 experimental Helix test, use only short prompts for one integration test, and align QA, B200, and waiver lists with the revised selections.

Changes

Disaggregated serving test selection

Layer / File(s) Summary
Narrow Helix accuracy coverage
tests/integration/defs/accuracy/test_disaggregated_serving.py
DeepSeek and Qwen3 Helix parametrizations are restricted to selected fifo_v2 padding configurations, and the DeepSeek V32 experimental Helix test is removed.
Update integration test selection
tests/integration/defs/disaggregated/test_disaggregated.py, tests/integration/test_lists/qa/llm_function_core.txt, tests/integration/test_lists/test-db/l0_dgx_b200.yml
The disaggregated generation test keeps only short prompts, while QA and B200 manifests select the revised Helix cases.
Align skipped test waivers
tests/integration/test_lists/waives.txt
Waived entries are replaced or removed to match the updated test matrix.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: bmarimuthu-nv

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the PR's main change: consolidating helix test coverage.
Description check ✅ Passed The description includes the required Description, Test Coverage, and PR Checklist sections and is sufficiently complete.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brb-nv

brb-nv commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60133 [ run ] triggered by Bot. Commit: eabd20f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60133 [ run ] completed with state SUCCESS. Commit: eabd20f
/LLM/main/L0_MergeRequest_PR pipeline #48514 completed with status: 'SUCCESS'

CI Report

Link to invocation

@brb-nv
brb-nv merged commit f4c5c93 into NVIDIA:main Jul 19, 2026
12 checks passed
@Shixiaowei02

Copy link
Copy Markdown
Collaborator

Thank you for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants