Skip to content

[https://nvbugs/6480574][fix] seed attrs bypassed by __new__ in pool session shutdown test #16630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JunyiXu-nv merged 2 commits into from
Jul 22, 2026
Merged

[https://nvbugs/6480574][fix] seed attrs bypassed by __new__ in pool session shutdown test #16630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df44d25
[https://nvbugs/6480574][fix] seed attrs bypassed by __new__ in pool …
JunyiXu-nv Jul 20, 2026
1571acd
[https://nvbugs/6480574][chore] unwaive test_pool_session_shutdown_ne…
JunyiXu-nv Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/integration/test_lists/waives.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ unittest/_torch/visual_gen/test_attention_integration.py::test_sage_attention_se
unittest/_torch/visual_gen/test_attention_integration.py::test_sage_attention_self_attention[int8-2-1560] SKIP (https://nvbugs/6198760)
unittest/auto_deploy/multigpu/custom_ops SKIP (https://nvbugs/6403920)
unittest/disaggregated/test_kv_transfer.py::test_transfer_worker_v2[tp4_pp1_to_tp2_pp2] SKIP (https://nvbugs/6426834)
unittest/executor/test_proxy_fast_death.py::test_pool_session_shutdown_never_blocks_after_release SKIP (https://nvbugs/6480574)
unittest/executor/test_rpc.py::TestRpcCorrectness::test_incremental_task_async SKIP (https://nvbugs/5741476)
unittest/executor/test_rpc_proxy.py SKIP (https://nvbugs/5605741)
unittest/executor/test_rpc_worker.py SKIP (https://nvbugs/5605741)
Expand Down
8 changes: 8 additions & 0 deletions tests/unittest/executor/test_proxy_fast_death.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,14 @@ def test_pool_session_shutdown_never_blocks_after_release():
pool = _Mock()
pool._pool.thread = None # no real manager thread to deregister
session.mpi_pool = pool
# __init__ is bypassed above; seed the attributes that shutdown() reads
# so the test exercises the release/shutdown contract, not attribute
# lookup on a raw-constructed session. Keep them minimal:
# * n_workers is only used by shutdown()'s log line.
# * _wait_shutdown gates the post-shutdown worker-exit barrier;
# the test targets the blocking-join guard, so leave it off.
session.n_workers = 1
session._wait_shutdown = False

session.release_exit_joins()
session.shutdown() # owner asks for the default blocking shutdown
Expand Down
Loading