Skip to content

[None][infra] Remove tensorrt install from docker container - #16679

Closed
yuanjingx87 wants to merge 1 commit into
NVIDIA:mainfrom
yuanjingx87:user/yuanjingx/remove_tensorrt
Closed

[None][infra] Remove tensorrt install from docker container#16679
yuanjingx87 wants to merge 1 commit into
NVIDIA:mainfrom
yuanjingx87:user/yuanjingx/remove_tensorrt

Conversation

@yuanjingx87

@yuanjingx87 yuanjingx87 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed --tensorrt from the Docker devel stage while retaining the other installation options.
  • Updated the related TensorRT removal comment for consistency.
  • No executable logic or public APIs were otherwise changed.

QA Engineer Review

No test changes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Yuanjing Xue <197832395+yuanjingx87@users.noreply.github.com>
@yuanjingx87

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "Build-Docker-Images"

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9515ed1a-faab-416b-845b-db9424f2f7a7

📥 Commits

Reviewing files that changed from the base of the PR and between a75e333 and a56f0b1.

📒 Files selected for processing (2)
  • docker/Dockerfile.multi
  • docker/common/install_base.sh

Walkthrough

The development Docker stage no longer passes --tensorrt to install.sh, while retaining other installation options. A related TensorRT cleanup comment is reworded without changing executable commands.

Changes

Docker installation configuration

Layer / File(s) Summary
Development image installation options
docker/Dockerfile.multi, docker/common/install_base.sh
The devel stage removes the --tensorrt option while retaining --polygraphy, --mpi4py, and --pytorch; the TensorRT cleanup comment is reworded without changing commands.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: dpitman-nvda

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly the untouched template and lacks the required issue/solution and test coverage details. Replace the template placeholders with a brief problem summary, the implemented change, and relevant test coverage.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: removing TensorRT install from the Docker container.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60753 [ run ] triggered by Bot. Commit: a56f0b1 Link to invocation

@tburt-nv

Copy link
Copy Markdown
Collaborator

Related to #16608?

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60753 [ run ] completed with state FAILURE. Commit: a56f0b1
/LLM/main/L0_MergeRequest_PR pipeline #49037 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants