Skip to content

[None][feat] Add BaseMultimodalDummyInputsBuilder to minimaxm3_vl - #16696

Merged
pcicotti merged 1 commit into
NVIDIA:mainfrom
pcicotti:minimaxm3-vl-dummy-inputs
Jul 22, 2026
Merged

[None][feat] Add BaseMultimodalDummyInputsBuilder to minimaxm3_vl#16696
pcicotti merged 1 commit into
NVIDIA:mainfrom
pcicotti:minimaxm3-vl-dummy-inputs

Conversation

@pcicotti

@pcicotti pcicotti commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Background

MiniMaxM3VLInputProcessor was missing BaseMultimodalDummyInputsBuilder as a base class, causing the following error at runtime:

AttributeError: 'MiniMaxM3VLInputProcessor' object has no attribute 'get_preferred_media_io_kwargs'

Summary

Add BaseMultimodalDummyInputsBuilder to the dynamically constructed _Registered class in get_minimax_m3_vl_input_processor_cls(), alongside the existing BaseMultimodalInputProcessor base.

Impact

No functional change beyond fixing the missing attribute — no new configuration, no API surface change.

Dev Engineer Review

  • Updated the dynamically registered MiniMax M3 VL input processor to inherit from BaseMultimodalDummyInputsBuilder alongside BaseMultimodalInputProcessor.
  • This resolves the missing get_preferred_media_io_kwargs interface required by the multimodal pipeline.
  • Change is narrowly scoped, introduces no configuration or public API changes, and has no apparent performance or error-handling impact.

QA Engineer Review

No test changes.

Signed-off-by: Pietro Cicotti <5833013+pcicotti@users.noreply.github.com>
@pcicotti
pcicotti requested a review from a team as a code owner July 22, 2026 00:52
@pcicotti

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 33cf4940-f3a5-45bf-8651-da90df2bf6a4

📥 Commits

Reviewing files that changed from the base of the PR and between 6fabfdc and b1a0487.

📒 Files selected for processing (1)
  • tensorrt_llm/_torch/models/modeling_minimaxm3_vl.py

Walkthrough

The dynamically registered MiniMaxM3VLInputProcessor class now inherits BaseMultimodalDummyInputsBuilder in addition to its existing multimodal input processor bases.

Changes

MiniMaxM3 VL processor registration

Layer / File(s) Summary
Extend registered processor interface
tensorrt_llm/_torch/models/modeling_minimaxm3_vl.py
The dynamically created _Registered class imports and inherits BaseMultimodalDummyInputsBuilder.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: brb-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, follows the repository's format, and clearly describes the main change.
Description check ✅ Passed The description explains the background, fix, and impact, but omits the requested Test Coverage section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60832 [ run ] triggered by Bot. Commit: b1a0487 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60832 [ run ] completed with state SUCCESS. Commit: b1a0487
/LLM/main/L0_MergeRequest_PR pipeline #49108 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@pcicotti

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@pcicotti
pcicotti enabled auto-merge (squash) July 22, 2026 15:48
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61009 [ run ] triggered by Bot. Commit: b1a0487 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61009 [ run ] completed with state SUCCESS. Commit: b1a0487
/LLM/main/L0_MergeRequest_PR pipeline #49267 completed with status: 'SUCCESS'

CI Report

Link to invocation

@pcicotti
pcicotti merged commit b294868 into NVIDIA:main Jul 22, 2026
13 checks passed
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 26, 2026
…IDIA#16696)

Signed-off-by: Pietro Cicotti <5833013+pcicotti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants