[NVBUG-6448152][perf] TEST ONLY; DO NOT REVIEW: exclude active transfers from scheduler capacity - #16736
Closed
chienchunhung wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --stage-list "GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1" |
Collaborator
|
PR_Github #60984 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #60984 [ run ] completed with state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST ONLY; DO NOT REVIEW
This is a one-factor performance diagnostic for the GB300 PP4 disaggregated workload.
Hypothesis
The CuTe-off discriminator completed 512/512 at 814.02 output tok/s, so automatic PP CuTe BF16 selection does not explain the current approximately 2x regression. The next bounded current-only candidate is the transfer-in-progress scheduler-accounting change, which makes generation-side transfers consume logical scheduler request capacity.
Diagnostic change
TRTLLM_NVBUG_6448152_EXCLUDE_DISAGG_GEN_TRANSFER_FROM_CAPACITY=1, exclude onlyDISAGG_GENERATION_TRANS_IN_PROGRESSfrom the logical max-request count in guaranteed-no-evict and max-utilization scheduling.NVBUG6448152_SCHED event=effective_configmarker.Verification
Interpretation
Do not review or merge this diagnostic.