[https://nvbugs/6499882][fix] Seed _multi_frontend_ipc_dir in bare proxy test helper - #16761
Merged
chienchunhung merged 1 commit intoJul 23, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe test proxy helper now initializes ChangesProxy cleanup test
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…oxy test helper Signed-off-by: Pranav Shrestha <254760092+pranav-nvidia@users.noreply.github.com>
pranav-nvidia
force-pushed
the
fix/nvbug-6499882-ipc-dir
branch
from
July 22, 2026 22:45
187b5ad to
c86d0c0
Compare
cascade812
approved these changes
Jul 22, 2026
Collaborator
|
/bot run |
Collaborator
|
PR_Github #61110 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #61110 [ run ] completed with state |
yuanjingx87
pushed a commit
to yuanjingx87/TensorRT-LLM
that referenced
this pull request
Jul 26, 2026
…oxy test helper (NVIDIA#16761) Signed-off-by: Pranav Shrestha <254760092+pranav-nvidia@users.noreply.github.com> Co-authored-by: Pranav Shrestha <254760092+pranav-nvidia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three
test_shutdown_*tests intest_proxy_fast_death.pybuild aGenerationExecutorProxyvia__new__(bypassing__init__) and callshutdown(), which readsself._multi_frontend_ipc_dir— an attribute only seeded in__init__. The bare-proxy helper never set it, so the tests raisedAttributeError.Seed
_multi_frontend_ipc_dir = Nonein_bare_proxy().NVBug: https://nvbugspro.nvidia.com/bug/6499882
Dev Engineer Review
_bare_proxy()test helper to initializeproxy._multi_frontend_ipc_dir = None, matching whatGenerationExecutorProxy.__init__would normally establish.shutdown()/GC cleanup from failing whenGenerationExecutorProxyinstances are created via__new__intest_proxy_fast_death.py.QA Engineer Review
tests/unittest/executor/test_proxy_fast_death.pyby modifying the_bare_proxy()helper only.test_shutdown_does_not_block_on_dead_enginetest_shutdown_keeps_blocking_semantics_when_engine_alivetest_shutdown_does_not_shut_down_external_sessionare the ones unblocked by the helper initialization.
tests/integration/test_lists/(and therefore no CI/manual QA coverage list updates were required).