Skip to content

[https://nvbugs/6499882][fix] Seed _multi_frontend_ipc_dir in bare proxy test helper - #16761

Merged
chienchunhung merged 1 commit into
NVIDIA:mainfrom
pranav-nvidia:fix/nvbug-6499882-ipc-dir
Jul 23, 2026
Merged

[https://nvbugs/6499882][fix] Seed _multi_frontend_ipc_dir in bare proxy test helper#16761
chienchunhung merged 1 commit into
NVIDIA:mainfrom
pranav-nvidia:fix/nvbug-6499882-ipc-dir

Conversation

@pranav-nvidia

@pranav-nvidia pranav-nvidia commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The three test_shutdown_* tests in test_proxy_fast_death.py build a GenerationExecutorProxy via __new__ (bypassing __init__) and call shutdown(), which reads self._multi_frontend_ipc_dir — an attribute only seeded in __init__. The bare-proxy helper never set it, so the tests raised AttributeError.

Seed _multi_frontend_ipc_dir = None in _bare_proxy().

NVBug: https://nvbugspro.nvidia.com/bug/6499882

Dev Engineer Review

  • Updated the _bare_proxy() test helper to initialize proxy._multi_frontend_ipc_dir = None, matching what GenerationExecutorProxy.__init__ would normally establish.
  • Prevents shutdown()/GC cleanup from failing when GenerationExecutorProxy instances are created via __new__ in test_proxy_fast_death.py.
  • No changes to runtime logic, configuration, public APIs, or test-list entries.

QA Engineer Review

  • Touched tests/unittest/executor/test_proxy_fast_death.py by modifying the _bare_proxy() helper only.
  • No test functions were added, removed, or modified; the existing shutdown tests:
    • test_shutdown_does_not_block_on_dead_engine
    • test_shutdown_keeps_blocking_semantics_when_engine_alive
    • test_shutdown_does_not_shut_down_external_session
      are the ones unblocked by the helper initialization.
  • No changes to tests/integration/test_lists/ (and therefore no CI/manual QA coverage list updates were required).
  • Verdict: sufficient.

@pranav-nvidia
pranav-nvidia marked this pull request as ready for review July 22, 2026 22:40
@pranav-nvidia
pranav-nvidia requested a review from a team as a code owner July 22, 2026 22:40
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bf5ca889-2145-452a-b6e9-dbf8b3d8b966

📥 Commits

Reviewing files that changed from the base of the PR and between 187b5ad and c86d0c0.

📒 Files selected for processing (1)
  • tests/unittest/executor/test_proxy_fast_death.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/unittest/executor/test_proxy_fast_death.py

Walkthrough

The test proxy helper now initializes _multi_frontend_ipc_dir to None, allowing shutdown cleanup to access the attribute when proxy construction bypasses __init__.

Changes

Proxy cleanup test

Layer / File(s) Summary
Initialize proxy cleanup state
tests/unittest/executor/test_proxy_fast_death.py
_bare_proxy() seeds _multi_frontend_ipc_dir before exercising shutdown cleanup.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: cascade812

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR explains the fix, but it omits the required Test Coverage and PR Checklist sections from the template. Add the missing template sections with relevant tests and checklist items, or note if test coverage is not applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the fix and follows the required ticket-and-type format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

…oxy test helper

Signed-off-by: Pranav Shrestha <254760092+pranav-nvidia@users.noreply.github.com>
@pranav-nvidia
pranav-nvidia force-pushed the fix/nvbug-6499882-ipc-dir branch from 187b5ad to c86d0c0 Compare July 22, 2026 22:45
@cascade812

Copy link
Copy Markdown
Collaborator

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61110 [ run ] triggered by Bot. Commit: c86d0c0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #61110 [ run ] completed with state SUCCESS. Commit: c86d0c0
/LLM/main/L0_MergeRequest_PR pipeline #49364 completed with status: 'SUCCESS'

CI Report

Link to invocation

@chienchunhung
chienchunhung merged commit 1d2e79e into NVIDIA:main Jul 23, 2026
10 checks passed
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 26, 2026
…oxy test helper (NVIDIA#16761)

Signed-off-by: Pranav Shrestha <254760092+pranav-nvidia@users.noreply.github.com>
Co-authored-by: Pranav Shrestha <254760092+pranav-nvidia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants