[TRTLLM-14571][infra] Enable container-local AutoTuner cache in CI - #16794
Conversation
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThe PR configures pytest runs to use a container-local AutoTuner profiling cache and updates cache deserialization to skip tactic entries that raise ChangesAutotuner cache reliability
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #61274 [ run ] triggered by Bot. Commit: |
|
PR_Github #61274 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61786 [ run ] triggered by Bot. Commit: |
|
PR_Github #61786 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #62074 [ run ] triggered by Bot. Commit: |
|
PR_Github #62074 [ run ] completed with state |
- Wire TLLM_AUTOTUNER_CACHE_PATH into pytest stages to reuse tactic profiling across testcases via a volatile container-local /tmp path. - Harden _deserialize_cache_data to skip non-literal tactics (SyntaxError) instead of crashing load_cache, e.g. Fp4QuantTactic IntEnum reprs. - Add regression test for the skip-on-load behavior. Signed-off-by: Yihui Lu <269394165+YihuiLu512@users.noreply.github.com>
- Drop the pinned Fp4QuantTactic example from the non-literal-tactic skip comment; point at NVIDIA#16782 for the serialize-side fix. - Decouple the regression test from the IntEnum: build the poisoned repr from a generic object and trim its docstring. Signed-off-by: Yihui Lu <269394165+YihuiLu512@users.noreply.github.com>
7600b13 to
ac34b8e
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #62186 [ run ] triggered by Bot. Commit: |
|
PR_Github #62186 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #62384 [ run ] triggered by Bot. Commit: |
JunyiXu-nv
left a comment
There was a problem hiding this comment.
Overall LGTM, the added catch sweep is non-blocking.
|
PR_Github #62384 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #62442 [ run ] triggered by Bot. Commit: |
|
PR_Github #62442 [ run ] completed with state |
The goal is to improve GPU utilization during CI runs.
Dev Engineer Review
jenkins/L0_Test.groovyto injectTLLM_AUTOTUNER_CACHE_PATHinto pytest runs, pointing to a container-local volatile/tmp/trtllm_autotuner_cache/autotuner_cache.json, with inline rationale to avoid writing to shared/bind-mounted paths due to unreliable locking over NFS.AutoTunerProfilingCache._deserialize_cache_dataintensorrt_llm/_torch/autotuner.pyto also catchSyntaxErrorfromast.literal_evalwhen cached tactic representations are not valid Python literals; it logs once and skips the bad entry instead of failing the entire cache load (preventing reuse of stale/incorrect tactics).load_cacheto raise.QA Engineer Review
test_load_cache_skips_non_literal_tactic()intests/unittest/_torch/misc/test_autotuner.py.tests/integration/test_lists/, and the new test is not listed intest-db/orqa/test lists.Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.