[TRTLLM-14609][chore] Remove legacy MoE path in CuteDslFusedMoE - #16863
Conversation
ConfigurableMoE has been the default MoE path for months (ENABLE_CONFIGURABLE_MOE defaults to 1) and drives compute through backend.run_moe while the wrapper owns communication and chunk scheduling. The backend-level legacy MoE forward path is dead code on that path. Remove it; run_moe and the live ConfigurableMoE contract (quantize_input, get_workspaces, supports_moe_output_in_alltoall_workspace, forward_fake, etc.) are unchanged. Signed-off-by: xxi <xxi@nvidia.com>
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe Cute DSL fused MoE module removes unused imports, the ChangesCute DSL MoE cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #61759 [ run ] triggered by Bot. Commit: |
|
PR_Github #61759 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61821 [ run ] triggered by Bot. Commit: |
|
PR_Github #61821 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61876 [ run ] triggered by Bot. Commit: |
|
PR_Github #61876 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61896 [ run ] triggered by Bot. Commit: |
|
/bot run --disable-fail-fast |
|
PR_Github #61906 [ run ] triggered by Bot. Commit: |
|
PR_Github #61896 [ run ] completed with state |
|
PR_Github #61906 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #61952 [ run ] triggered by Bot. Commit: |
|
PR_Github #61952 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #62005 [ run ] triggered by Bot. Commit: |
|
PR_Github #62005 [ run ] completed with state |
Description
For the sake of MoE code health, this PR removes the legacy (pre-
ConfigurableMoE) forward path fromCuteDslFusedMoE.ConfigurableMoEhas been the default MoE path for months (ENABLE_CONFIGURABLE_MOEdefaults to"1"), so the backend-internal forward pipeline and the legacy all-to-all method selection are no longer reachable in the default flow.What is removed (
tensorrt_llm/_torch/modules/fused_moe/fused_moe_cute_dsl.py)select_alltoall_method_type()forward_chunk()Net effect: 43 deletions in a single file.
What is deliberately preserved
ConfigurableMoE/MoEScheduleris untouched:run_moe()andsupports_moe_output_in_alltoall_workspace().Test Coverage
Verified on OCI GB200 (1 node, 4 GPUs) with the container pinned by
jenkins/current_image_tags.properties, runningtests/unittest/_torch/modules/moe/test_moe_module.pyfiltered to this backend (excluding theMEGAMOE_CUTEDSLvariant):test_configurable_moe_single_gputest_configurable_moe_multi_gputest_configurable_moe_multi_gpu_eplb31 passed, 0 failed.
PR Checklist
[JIRA/NVBUG][type] descriptionDev Engineer Review
ConfigurableMoEforward path fromCuteDslFusedMoE, includingselect_alltoall_method_type()andforward_chunk().allgatherandAlltoallMethodTypeimports.ConfigurableMoE/MoESchedulercontract remains unchanged, includingrun_moe()andsupports_moe_output_in_alltoall_workspace().QA Engineer Review