Skip to content

[NVBUG-6327718][test] Unwaive test_disaggregated_videomme[nemotron_na… - #17031

Draft
aswinvisva wants to merge 1 commit into
NVIDIA:mainfrom
aswinvisva:avisva/unwaive-nvbug-6327718
Draft

[NVBUG-6327718][test] Unwaive test_disaggregated_videomme[nemotron_na…#17031
aswinvisva wants to merge 1 commit into
NVIDIA:mainfrom
aswinvisva:avisva/unwaive-nvbug-6327718

Conversation

@aswinvisva

@aswinvisva aswinvisva commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

…no_v3_omni_fp8] on B200 and H20

The root cause of the pre-fix failure — TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union at tensorrt_llm/executor/proxy.py when the test infrastructure's session-reuse cache monkey-patches MpiPoolSession in the proxy module namespace with a factory function — is already fixed on main. The proxy code was refactored to identify pool-backed sessions by excluding (MpiCommSession, RemoteMpiCommSessionClient) instead of isinstance(x, MpiPoolSession).

Remove the two waivers linked to NVBug 6327718 so CI can verify the fix on both platforms.

Dev Engineer Review

  • Removed the two nvbug: 6327718 waivers for the targeted test on B200 and H20.
  • The change is correctly scoped to tests/integration/test_lists/waives.txt with no code or API changes.
  • Waiver formatting and platform coverage should remain consistent with the surrounding entries.

QA Engineer Review

  • Test-list-only change; no test-db/ or qa/ files were modified.
  • Removed CI waiver entries for TestVideoMMEEPD::test_disaggregated_videomme[nemotron_nano_v3_omni_fp8] on full:B200 and full:H20.
  • Verdict: needs follow-up pending CBTS coverage data.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…no_v3_omni_fp8] on B200 and H20

The root cause of the pre-fix failure — `TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union` at
`tensorrt_llm/executor/proxy.py` when the test infrastructure's session-reuse cache monkey-patches
`MpiPoolSession` in the proxy module namespace with a factory function — is already fixed on main. The proxy code
was refactored to identify pool-backed sessions by excluding `(MpiCommSession, RemoteMpiCommSessionClient)`
instead of `isinstance(x, MpiPoolSession)`.

Remove the two waivers linked to NVBug 6327718 so CI can verify the fix on both platforms.

Signed-off-by: Aswin Visva <31215515+aswinvisva@users.noreply.github.com>
@aswinvisva
aswinvisva requested review from a team as code owners July 29, 2026 22:47
@aswinvisva
aswinvisva marked this pull request as draft July 29, 2026 22:48
@aswinvisva

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "DGX_B200-PyTorch-4"

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 379b5893-92c2-4acb-9e35-80cf7e46358d

📥 Commits

Reviewing files that changed from the base of the PR and between c45ad83 and 08015b1.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

Two waiver entries are removed from the integration test waiver list, allowing the disaggregated VideoMME test to run on B200 and H20.

Changes

Test waiver cleanup

Layer / File(s) Summary
Remove VideoMME waivers
tests/integration/test_lists/waives.txt
Removes SKIP entries for the targeted test on full:B200 and full:H20.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: qijune, brnguyen2

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, but the required Test Coverage and PR Checklist sections are left empty. Add a brief Test Coverage note and complete the PR Checklist items, or explain why they do not apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the main change: removing a waiver for the affected test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62622 [ run ] triggered by Bot. Commit: 08015b1 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62622 [ run ] completed with state SUCCESS. Commit: 08015b1
/LLM/main/L0_MergeRequest_PR pipeline #50762 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants