[NVBUG-6448152][test] TEST ONLY: 4x admission-window discriminator - #17032
[NVBUG-6448152][test] TEST ONLY: 4x admission-window discriminator#17032chienchunhung wants to merge 11 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Yihan Wang <yihwang@nvidia.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 6fc7f33)
…sensus factor Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 9c8bf59)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 4b182f1)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
|
/bot run --disable-fail-fast --stage-list "GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1" |
|
PR_Github #62627 [ run ] triggered by Bot. Commit: |
Terminal evidence — valid workload, admission-magnitude discriminator censoredThe exact frozen GB300 workload completed successfully at head
The metric remains effectively identical to the adjacent 1× admission baseline: +0.85 output tok/s, or +0.106%. It is also only 52.81% of the 1,515.84 output tok/s native-parent result. However, this run does not satisfy the discriminator's capacity-exercise requirement. Runtime reported a base window of 4,097 transfer blocks and an effective 4× window of 16,388 blocks on all CTX and GEN ranks, correcting the pre-run 2,049/8,196 estimate. The required Therefore:
The recorded pytest failure was solely the expected performance gate against the historical fast baseline. A post-result retry classifier also matched transient startup Closing this TEST ONLY draft unmerged; the branch is preserved. |
|
PR_Github #62627 [ run ] completed with state
|
TEST ONLY — do not merge
This is a single-factor performance discriminator for the regression introduced by the admission and bounded-polling change.
The adjacent source comparison is now categorical: the native parent completed at 1515.84 output tok/s, while the exact admission commit completed at 799.73 output tok/s in the frozen admission-commit diagnostic. The earlier 2× logical admission-window diagnostic remained slow at 799.32 output tok/s, so this draft does not repeat that treatment.
Frozen baseline
dd4a7ac2992f2b02dce381ce4e630c4ba4199436899bdb3449199c821d157c9690f7d9aae9551e66b6eacd1f(the admission/bounded-polling commit)4571e90b1ec4c4effd673ceab99e7479158cd87f270608b5b53c623fb318fa24bf3a31ec16219d77Runtime overlay, current CI harness and image inputs, exact workload, C++ consensus factor, cancellation-off setting, topology, selector, physical NIXL buffers, and active-transfer accounting are unchanged from the valid 1× baseline.
Only treatment
The exact GB300 workload sets
TRTLLM_DIAGNOSTIC_DISAGG_ADMISSION_BUDGET_MULTIPLIER=4. This multiplies only the PyExecutor logical transfer-admission budget. The CTX and GENmax_tokens_in_buffervalues remain131104; no physical NIXL buffer is enlarged.For this workload the base logical window is 2,049 blocks and the 4× effective window is 8,196 blocks. One full request uses 2,048 blocks, so four full transfers use 8,192 blocks.
The diagnostic marker is deliberately stronger than a configuration check: it latches only above the 3× comparison window (6,147 blocks). Therefore the expected
used=8192marker proves that the fourth logical window was exercised and necessarily exceeds the previously tested 2× effective window of 4,098 blocks. It cannot be satisfied by the oversized-idle-head exception or active transfers alone.Required valid evidence
Build/import failure, timeout, cancellation, protocol mismatch, any failed request, invalid metric, or failure to prove capacity beyond the previous 2× window censors the result.
Interpretation
Validation
transformers; no test was claimed as executed.