[NVBUG-6448152][test] TEST ONLY: bypass disagg transfer admission - #17072
Closed
chienchunhung wants to merge 11 commits into
Closed
[NVBUG-6448152][test] TEST ONLY: bypass disagg transfer admission#17072chienchunhung wants to merge 11 commits into
chienchunhung wants to merge 11 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Yihan Wang <yihwang@nvidia.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 6fc7f33)
…sensus factor Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 9c8bf59)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 4b182f1)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
This draft was detected as conflicting with the latest Closing it unmerged while preserving the exact diagnostic branch at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST ONLY — do not merge
This diagnostic isolates the reachable PyExecutor transfer-admission gate within the adjacent native admission/bounded-polling change.
The immediate parent checkpoint completed at 1,515.84 output tok/s. The adjacent native admission-change checkpoint completed at 799.73 output tok/s. Both used the same current-runtime harness, protected workload, and asynchronous-consensus factor.
Treatment
b6eacd1fbaseline construction, runtime overlay, image selection, harness, selector, topology, NIXL configuration, consensus mode, and cancellation setting.TRTLLM_DIAGNOSTIC_DISAGG_ADMISSION_BYPASS=1only in the exact GB300 workload YAML.wait_for_progress=falseinstead of applying the transfer-admission selection.DIAGNOSTIC OBSERVEDmarker per executor only when a pure comparison shows the default gate would have deferred requests. The marker reports candidate/admitted/deferred counts and transfer-block totals, never request IDs.Local verification
Required experiment evidence
The sole target is
GB300-12_GPUs-3_Nodes-PyTorch-Disagg-PerfSanity-CTX1-NODE1-GPU4-GEN1-NODE2-GPU8-Post-Merge-1, selectordisagg_upload-e2e-gb300_deepseek-r1-fp4_128k8k_con256_ctx1_pp4_gen1_dep8_eplb0_mtp1_ccb-NIXL.A valid result requires all 512 requests to succeed, the bypass marker to prove the default gate would bind on every relevant GEN scheduling rank, consensus active on CTX PP ranks 0-3 with cancellation disabled, clean CTX/GEN/application shutdown, and a valid official output-token metric.