[NVBUG-6448152][test] isolate double disagg admission interaction - #17086
Closed
chienchunhung wants to merge 12 commits into
Closed
[NVBUG-6448152][test] isolate double disagg admission interaction#17086chienchunhung wants to merge 12 commits into
chienchunhung wants to merge 12 commits into
Conversation
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Yihan Wang <yihwang@nvidia.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 6fc7f33)
…sensus factor Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 9c8bf59)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com> (cherry picked from commit 4b182f1)
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
Superseded before any CI trigger. This draft combines two factors: native logical-slot accounting and the Python transport-admission bypass. The next diagnostic will keep the PR #15356 transport-budget gate enabled at its normal 1× setting and vary only whether Closing unmerged; the diagnostic branch remains frozen and preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST ONLY — DO NOT MERGE
This diagnostic isolates whether the C++/native transceiver regression introduced by the admission and bounded-polling change is caused by serial enforcement at two admission layers.
Adjacent matched evidence already localizes the regression to that commit as a unit: the exact parent completed 512/512 at 1515.84 output tok/s, while the exact child completed 512/512 at 799.73 output tok/s. Sanitized adjacent evidence
A prior Python admission-bypass diagnostic completed at 800.49 output tok/s, but its divergence marker never fired: the native capacity scheduler had already reduced every eligible batch before the Python gate. That run therefore changed no admission decision.
Treatment
On the exact frozen child baseline, this draft:
DISAGG_GENERATION_TRANS_IN_PROGRESSrequests from the nativeGuaranteedNoEvictSchedulerlogical request-slot count;Only six treatment files differ from the frozen baseline. Runtime, image, model, workload, selector, topology, physical buffers, scheduler policy, async consensus, cancellation mode, request count, concurrency, and round count remain frozen.
Required causal evidence
The run is valid only with:
event=exercisedmarker and shutdown summary on each relevant GEN scheduling rank;event=python_gate_exercisedmarker plus its shutdown summary;Interpretation:
The C++ capacity-output histogram is not a device-forward batch histogram, and Python “treatment admitted” means passed the gate, not completed transfer.
Reproducibility and review
dd4a7ac2992f2b02dce381ce4e630c4ba4199436;8c1be138b193c333f170d2179ac9dba426c7b91c;cc75c9866a5d67b0aebd46a669bf90765cdde423;b598bfbdddbe87f407282ae5605f500a9ef4158e2b1baa4f9dc69885cd4f5f1e;7fdad6ad098c8efb843f753ff9887cc7bfa77aea;Configured hooks, Python 3.13 compile, test-list AST validation, diff checks, DCO, and independent C++/Python/no-confound reviews passed. Focused Python pytest cannot collect locally because
transformersis absent; no local C++ build tree is available.Because the final merge is ancestry-only, audit the causal change only as the frozen baseline to the signed treatment commit. This draft must be closed unmerged after terminal evidence, and the branch must be preserved.