Skip to content

[https://nvbugs/6537081][fix] Fix import error - #17112

Merged
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-nvbug-6537081
Jul 31, 2026
Merged

[https://nvbugs/6537081][fix] Fix import error#17112
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-nvbug-6537081

Conversation

@2ez4bz

@2ez4bz 2ez4bz commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Updated tensorrt_llm/llmapi/__init__.py.
  • Added DeepSeekV4SparseAttentionConfig to the public LLM argument configuration imports.
  • Exported MultimodalConfig through tensorrt_llm.llmapi.
  • These changes address the reported import error and align the public API exports with the available configuration classes.
  • No performance or error-handling changes were introduced.

QA Engineer Review

No test changes.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
@2ez4bz
2ez4bz requested a review from a team as a code owner July 31, 2026 07:04
@2ez4bz

2ez4bz commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@2ez4bz
2ez4bz enabled auto-merge (squash) July 31, 2026 07:05
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62987 [ run ] triggered by Bot. Commit: fdccaa0 Link to invocation

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2cb94826-5bbd-4b5d-90bb-4dcbff7dbb54

📥 Commits

Reviewing files that changed from the base of the PR and between b118fc3 and fdccaa0.

📒 Files selected for processing (1)
  • tensorrt_llm/llmapi/__init__.py

Walkthrough

The LLM API module now imports DeepSeekV4SparseAttentionConfig and publicly exports MultimodalConfig.

Changes

LLM API exports

Layer / File(s) Summary
Update public configuration exports
tensorrt_llm/llmapi/__init__.py
The module imports DeepSeekV4SparseAttentionConfig and adds MultimodalConfig to __all__.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: bowenfu, allisonlim-nv, zhaoyangwang-nvidia

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the template and checklist, but the Description and Test Coverage sections are empty. Add a concise explanation of the issue and solution, and list the relevant tests or explain why no tests are required.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the import error and follows the required NVBugs and fix format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #62987 [ run ] completed with state SUCCESS. Commit: fdccaa0
/LLM/main/L0_MergeRequest_PR pipeline #51094 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@2ez4bz

2ez4bz commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63060 [ run ] triggered by Bot. Commit: fdccaa0 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63060 [ run ] completed with state SUCCESS. Commit: fdccaa0
/LLM/main/L0_MergeRequest_PR pipeline #51159 completed with status: 'SUCCESS'

CI Report

Link to invocation

@2ez4bz
2ez4bz merged commit e34d3d4 into NVIDIA:main Jul 31, 2026
13 checks passed
yuanjingx87 pushed a commit that referenced this pull request Aug 1, 2026
Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants