Skip to content

[https://nvbugs/6451425][fix] Remove llama3 eagle test waive - #17128

Merged
mikeiovine merged 1 commit into
NVIDIA:mainfrom
mikeiovine:remove-waive
Jul 31, 2026
Merged

[https://nvbugs/6451425][fix] Remove llama3 eagle test waive#17128
mikeiovine merged 1 commit into
NVIDIA:mainfrom
mikeiovine:remove-waive

Conversation

@mikeiovine

@mikeiovine mikeiovine commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Description

Issue with this test was fixed by #16444.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Dev Engineer Review

  • Removed the unittest/_torch/speculative/test_eagle3.py::test_llama_eagle3[...] waiver from tests/integration/test_lists/waives.txt.
  • The change has the correct scope and format.
  • No duplicate waiver or related stale entry remains.
  • No API, performance, or error-handling changes are included.
  • Verdict: sufficient.

QA Engineer Review

  • Modified no test-db/ or qa/ files.
  • Removed one entry from tests/integration/test_lists/waives.txt.
  • No test functions changed.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

Signed-off-by: Mike Iovine <miovine@nvidia.com>
@mikeiovine

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 13fdccd2-3a24-4e5a-b494-eefcba921cc2

📥 Commits

Reviewing files that changed from the base of the PR and between e6568c3 and 51b16a3.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

The integration waiver list removes the skipped test_llama_eagle3 entry associated with NVBug 6451425.

Changes

Test waiver update

Layer / File(s) Summary
Remove Eagle3 waiver
tests/integration/test_lists/waives.txt
Removes the waiver entry for the test_llama_eagle3 speculative decoding test.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: schetlur-nv, bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the NVBugs issue, fix type, and removal of the llama3 Eagle test waiver.
Description check ✅ Passed The description explains the issue, identifies the fixing pull request, records test coverage as N/A, and includes the completed checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63050 [ run ] triggered by Bot. Commit: 51b16a3 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63050 [ run ] completed with state SUCCESS. Commit: 51b16a3
/LLM/main/L0_MergeRequest_PR pipeline #51152 completed with status: 'SUCCESS'

CI Report

Link to invocation

@mikeiovine
mikeiovine merged commit d91d41a into NVIDIA:main Jul 31, 2026
12 checks passed
@mikeiovine
mikeiovine deleted the remove-waive branch July 31, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants