Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 51267 - #17184

Merged
dominicshanshan merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260803-062319
Aug 3, 2026
Merged

[None][infra] Waive 1 failed cases for main in pre-merge 51267#17184
dominicshanshan merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260803-062319

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @dominicshanshan)
Target branch: main
Bug(s): 6550803

Waive entries added

unittest/_torch/executor/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_promoted_context_precedes_speculative_overlap_generation SKIP (https://nvbugs/6550803)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added one SKIP waiver for PyTorchModelEngineTestCase::test_promoted_context_precedes_speculative_overlap_generation.
  • Linked the waiver to NVBug 6550803.
  • The change is limited to tests/integration/test_lists/waives.txt.
  • No duplicate waiver or unintended scope change was identified.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt by adding one waiver entry.
  • No test-db/ or qa/ files were modified.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

Bug(s): 6550803
Requested by: @dominicshanshan

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The integration waiver list now skips PyTorchModelEngineTestCase::test_promoted_context_precedes_speculative_overlap_generation and references NVBug 6550803.

Changes

Integration test waiver

Layer / File(s) Summary
Add PyTorch model engine waiver
tests/integration/test_lists/waives.txt
Adds a skip entry for the promoted-context precedence test during speculative overlap generation. The entry references NVBug 6550803.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: schetlur-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the infrastructure change and states that one failed test case is waived for the main branch.
Description check ✅ Passed The description identifies the failed test, waiver action, target branch, bug reference, and automation source.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 387: Add the repository-standard NVIDIA copyright header, including the
current copyright year, at the beginning of
tests/integration/test_lists/waives.txt while preserving the existing waiver
entry unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 234e6f05-7663-4acf-9952-d23e47791d92

📥 Commits

Reviewing files that changed from the base of the PR and between 74f3ccf and a20da0c.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt
@dominicshanshan

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive only"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63420 [ skip ] triggered by Bot. Commit: a20da0c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #63420 [ skip ] completed with state SUCCESS. Commit: a20da0c
Skipping testing for commit a20da0c

Link to invocation

@dominicshanshan
dominicshanshan merged commit c5427c5 into NVIDIA:main Aug 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants