[https://nvbugs/6550126][fix] Renamed the integration test's kwarg and its constant to… - #17207
Conversation
…age LPIPS tests PR NVIDIA#16384 (Qwen Image CFG parallelism) renamed QwenImagePipeline.forward()'s CFG knob from true_cfg_scale to negative_prompt_cfg_scale and updated the unit tests, but not the integration LPIPS call site, so both QwenImage LPIPS tests raised TypeError. Numerics are unchanged: with an empty negative prompt and scale 4.0 the old do_true_cfg and new use_negative_prompt_cfg are both true, and the guidance math was extracted verbatim into _combine_negative_prompt_cfg. Both tests score 0.009006 against the existing golden. Also drops the two now-obsolete waives.txt entries for this bug. Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughThe QwenImage LPIPS visual-generation test now uses ChangesQwenImage LPIPS validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #63539 [ run ] triggered by Bot. Commit: |
|
PR_Github #63539 [ run ] completed with state |
StanleySun639
left a comment
There was a problem hiding this comment.
LGTM if the target test case can pass.
Summary
QwenImagePipeline.forward()'s CFG kwargtrue_cfg_scale→negative_prompt_cfg_scaleand updated the three unit-test files, but left the integration LPIPS call site on the old name, soforward()raisedTypeError: unexpected keyword argument 'true_cfg_scale'.negative_prompt_cfg_scale/QWENIMAGE_LPIPS_NEGATIVE_PROMPT_CFG_SCALE, corrected the stale explanatory comment, and removed the two now-obsoletewaives.txtentries for this bug (the Qwen-Image-Layered call site at line 980 correctly keepstrue_cfg_scale, since that pipeline's signature is unchanged).Test plan
Links
Dev Engineer Review
true_cfg_scaletonegative_prompt_cfg_scale.QwenImagePipeline.forward().true_cfg_scalefor Qwen-Image-Layered because its API is unchanged.waives.txt.TypeError. The numerical result remains0.009006.QA Engineer Review
tests/integration/defs/examples/visual_gen/test_visual_gen.py.tests/integration/test_lists/waives.txt.