Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 53139 - #17517

Merged
pranav-nvidia merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260811-203523
Aug 11, 2026
Merged

[None][infra] Waive 1 failed cases for main in pre-merge 53139#17517
pranav-nvidia merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260811-203523

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @pranav-nvidia)
Target branch: main
Bug(s): 6594241

Waive entries added

full:DGX_B200/disaggregated/test_disaggregated.py::test_disaggregated_gpt_oss_120b_harmony[gpt_oss/gpt-oss-120b] SKIP (https://nvbugs/6594241)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added one correctly scoped waiver for test_disaggregated_gpt_oss_120b_harmony[gpt_oss/gpt-oss-120b].
  • Linked the waiver to NVBugs issue 6594241.
  • No public API or code changes.

QA Engineer Review

  • Modified no test-db/ or qa/ files.
  • Added one entry to tests/integration/test_lists/waives.txt.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

Bug(s): 6594241
Requested by: @pranav-nvidia

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@dpitman-nvda

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Waive only"

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The integration waiver list now skips the DGX B200 disaggregated GPT-OSS 120B test and references NVBugs issue 6594241.

Changes

GPT-OSS integration test waiver

Layer / File(s) Summary
Add DGX B200 test waiver
tests/integration/test_lists/waives.txt
Adds a skip record for test_disaggregated_gpt_oss_120b_harmony[gpt_oss/gpt-oss-120b] on DGX B200.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: brnguyen2, bowenfu

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the infrastructure waiver and states that one failed pre-merge case is waived for main.
Description check ✅ Passed The description explains the waiver, identifies the affected test, links NVBugs 6594241, and records the added skip entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tests/integration/test_lists/waives.txt (1)

1-1: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Handle SPDX comments before adding the header.

parse_and_validate_test_list ignores # lines, but verify_waive_list processes every non-empty line. An SPDX header would be reported as a non-existent test. Update the raw waiver checks to skip comments, then add the 2026 NVIDIA SPDX header.

Coverage: tests/integration/test_lists/waives.txt adds one waiver and removes none. No test functions or test-db/ or qa/ entries changed. CBTS coverage data is unavailable. Verdict: needs follow-up.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 1, Update verify_waive_list
to ignore comment lines beginning with #, matching parse_and_validate_test_list
behavior, then add the 2026 NVIDIA SPDX header to
tests/integration/test_lists/waives.txt while preserving the existing waiver
entry.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 1: Update verify_waive_list to ignore comment lines beginning with #,
matching parse_and_validate_test_list behavior, then add the 2026 NVIDIA SPDX
header to tests/integration/test_lists/waives.txt while preserving the existing
waiver entry.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 572471ae-0e5e-4742-a33f-397c5560e570

📥 Commits

Reviewing files that changed from the base of the PR and between 6930568 and c18338e.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — the comments below are optional touch-ups, not blockers.

Entry is well-formed and correctly placed: the ID matches tests/integration/test_lists/test-db/l0_dgx_b200.yml:51 verbatim, and line 189 keeps the file's sort order. The test also appears in tests/integration/test_lists/qa/llm_function_core.txt:874; confirm the QA list honors waives.txt if that run matters here.

@dpitman-nvda

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Waive only"

@pranav-nvidia
pranav-nvidia enabled auto-merge (squash) August 11, 2026 20:47
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65388 [ skip ] triggered by Bot. Commit: c18338e Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65388 [ skip ] completed with state SUCCESS. Commit: c18338e
Skipping testing for commit c18338e

Link to invocation

@pranav-nvidia
pranav-nvidia merged commit 6de751a into NVIDIA:main Aug 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants