Skip to content

Add initial list of CODEOWNERS - #4105

Merged
kevinch-nv merged 1 commit into
NVIDIA:mainfrom
kevinch-nv:dev/kevinch-add-codeowners
May 9, 2025
Merged

Add initial list of CODEOWNERS#4105
kevinch-nv merged 1 commit into
NVIDIA:mainfrom
kevinch-nv:dev/kevinch-add-codeowners

Conversation

@kevinch-nv

Copy link
Copy Markdown
Collaborator

Adds Initial List of CODEOWNERS

Test Coverage

N/A

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@hlu1
hlu1 requested review from chzblych and kaiyux May 7, 2025 22:39
Comment thread .github/CODEOWNERS Outdated
@hlu1
hlu1 requested a review from byshiue May 7, 2025 22:42
Comment thread .github/CODEOWNERS Outdated
@kevinch-nv
kevinch-nv force-pushed the dev/kevinch-add-codeowners branch 2 times, most recently from 5ea2260 to dacc90e Compare May 8, 2025 23:20
@kevinch-nv

Copy link
Copy Markdown
Collaborator Author

@hlu1 @chzblych can you review again? If everything looks good we can merge

Signed-off-by: Kevin Chen <kevinch@nvidia.com>
@hlu1

hlu1 commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Looks good to me.

@hlu1

hlu1 commented May 8, 2025

Copy link
Copy Markdown
Collaborator

/bot skip --comment "no code changes"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #4608 [ skip ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #4608 [ skip ] completed with state SUCCESS
Skipping testing for commit dacc90e

@hlu1
hlu1 requested review from juney-nvidia and litaotju May 9, 2025 03:09
@kevinch-nv
kevinch-nv merged commit aa7300e into NVIDIA:main May 9, 2025
Funatiq added a commit to Funatiq/TensorRT-LLM that referenced this pull request May 12, 2025
This reverts commit aa7300e.

Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
MartinMarciniszyn pushed a commit that referenced this pull request May 12, 2025
This reverts commit aa7300e.

Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants