fix/ replace sanity test for nemotron h with a correctness test - #4147
fix/ replace sanity test for nemotron h with a correctness test#4147omera-nv wants to merge 11 commits into
Conversation
01fa527 to
f42cfba
Compare
|
/bot run |
|
PR_Github #4514 [ run ] triggered by Bot |
|
PR_Github #4514 [ run ] completed with state |
|
/bot run |
|
PR_Github #4546 [ run ] triggered by Bot |
|
PR_Github #4546 [ run ] completed with state |
f42cfba to
1b4cf13
Compare
|
/bot run |
|
PR_Github #4862 [ run ] triggered by Bot |
|
PR_Github #4862 [ run ] completed with state |
Signed-off-by: Omer Ullman Argov <118735753+omera-nv@users.noreply.github.com>
Signed-off-by: Omer Ullman Argov <118735753+omera-nv@users.noreply.github.com>
Signed-off-by: Omer Ullman Argov <118735753+omera-nv@users.noreply.github.com>
1b4cf13 to
9b31dcd
Compare
Signed-off-by: Omer Ullman Argov <118735753+omera-nv@users.noreply.github.com>
9b31dcd to
05de495
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the basic sanity test for Nemotron H with a proper correctness test that compares model outputs against known good values from mcore. Key changes include:
- Removal of the old sanity test and configuration dictionary.
- Addition of a new correctness test with proper GPU memory checks and token generation.
- Integration of weights loading, tokenizer initialization, and logprobs comparison.
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
…atched forward test Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
…lling the decoded tokens Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
|
/bot run |
|
PR_Github #5616 [ run ] triggered by Bot |
|
PR_Github #5616 [ run ] completed with state |
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
|
/bot run |
|
PR_Github #5623 [ run ] triggered by Bot |
|
PR_Github #5623 [ run ] completed with state |
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
|
/bot run |
|
PR_Github #5628 [ run ] triggered by Bot |
|
PR_Github #5628 [ run ] completed with state |
Pull Request is not mergeable
|
/bot run |
1 similar comment
|
/bot run |
|
Replaced by PR #4444 |
[TRTLLM-5085][fix] Nemotron H correctness test
Description
Nemotron H was lacking a correctness test due to a missing public reference.
This PR replaces the basic sanity test with a proper correctness test against known good outputs from mcore.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.