Skip to content

Cherry-pick commits from feat/llama4 to main - #4189

Closed
chenfeiz0326 wants to merge 3 commits into
NVIDIA:mainfrom
chenfeiz0326:user/chenfeiz/cherry-pick-llama4-change-1
Closed

Cherry-pick commits from feat/llama4 to main#4189
chenfeiz0326 wants to merge 3 commits into
NVIDIA:mainfrom
chenfeiz0326:user/chenfeiz/cherry-pick-llama4-change-1

Conversation

@chenfeiz0326

@chenfeiz0326 chenfeiz0326 commented May 9, 2025

Copy link
Copy Markdown
Collaborator

Cherry-pick commits from feat/llama4 to main

Please write the PR title by following template:

[JIRA ticket link/nvbug link/github issue link][fix/feat/doc/infra/...] <summary of this PR>

For example, assume I have a PR hope to support a new feature about cache manager of Jira TRTLLM-1000 ticket, it would be like

[TRTLLM-1000][feat] Support a new feature about cache manager

Description

This PR cherry-picks feat/llama4's commits to main.

Perf

===========================================================
= PERFORMANCE OVERVIEW
===========================================================
Request Throughput (req/sec):                     0.7471
Total Output Throughput (tokens/sec):             897.0175
Total Token Throughput (tokens/sec):              1679.6140
Total Latency (ms):                               42833.0554
Average request latency (ms):                     1338.4794
Per User Output Throughput [w/ ctx] (tps/user):   900.4043
Per GPU Output Throughput (tps/gpu):              112.1272
Average time-to-first-token [TTFT] (ms):          52.7782
Average time-per-output-token [TPOT] (ms):        1.0700
Per User Output Speed (tps/user):                 936.9597

-- Acceptance Rate Details --------------------------------

[AR] MINIMUM: 2.63
[AR] MAXIMUM: 3.18
[AR] AVERAGE: 2.99
[AR] P50    : 3.04
[AR] P90    : 3.15
[AR] P95    : 3.17
[AR] P99    : 3.18
===========================================================

Accuracy verification

MMLU weighted average accuracy: 85.91 (14042)

GPQA:

{'score:std': np.float64(0.4969039949999533), 'score:stderr': 0.03540294377095367, 'score': np.float64(0.5555555555555556), 'task_name': 'gpqa_diamond'}

Output tokens:

[0] Prompt: 'Hello, my name is', Generated text: ' {{ name }} and I am {{ age }} years old.\n    </body>\n</html>\n"""\n\n# Define the data to be used in the template\ndata = {\n    "name": "John Doe",\n    "age": 30\n}\n\n# Render the template with the data\nrendered_template'
[1] Prompt: 'The president of the United States is', Generated text: ' the head of state and head of government of the United States, and is also the commander-in-chief of the armed forces. The president is responsible for executing the laws and policies of the government, and is also responsible for representing the United States on the international stage. The president is elected by the people'
[2] Prompt: 'The capital of France is', Generated text: ' Paris, and it is known for its rich history, art, and culture. The city is home to many famous landmarks, including the Eiffel Tower, the Louvre Museum, and Notre-Dame Cathedral. Paris is also known for its fashion, cuisine, and romantic atmosphere, making it a popular destination'
[3] Prompt: 'The future of AI is', Generated text: ' a topic of much debate and speculation. As we continue to develop and refine AI technologies, what can we expect the future of AI to hold, and how will it impact various aspects of our lives and society as a whole?\n\n1. **Advancements in AI Capabilities**: The future of AI is expected to'

@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #4711 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #4711 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3398 completed with status: 'FAILURE'

@chenfeiz0326 chenfeiz0326 changed the title Cherry-pick feat/llama4's 1-17 commits to main Cherry-pick feat/llama4's 1-31 to main May 11, 2025
@chenfeiz0326
chenfeiz0326 requested a review from yuxianq as a code owner May 11, 2025 08:59
@chenfeiz0326 chenfeiz0326 changed the title Cherry-pick feat/llama4's 1-31 to main Cherry-pick the first batch of commits from feat/llama4 to main May 12, 2025
@chenfeiz0326
chenfeiz0326 force-pushed the user/chenfeiz/cherry-pick-llama4-change-1 branch from 5229cc2 to ec17c6c Compare May 12, 2025 06:06
@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #4834 [ run ] triggered by Bot

Comment thread tensorrt_llm/_torch/modules/gated_mlp.py Outdated
Comment thread tensorrt_llm/_torch/modules/linear.py Outdated
@Funatiq
Funatiq removed their request for review May 12, 2025 09:57
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #4834 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3500 completed with status: 'FAILURE'

@chenfeiz0326
chenfeiz0326 requested a review from lfr-0531 as a code owner May 12, 2025 11:36
Comment thread tensorrt_llm/_torch/modules/linear.py Outdated
@chenfeiz0326
chenfeiz0326 force-pushed the user/chenfeiz/cherry-pick-llama4-change-1 branch 2 times, most recently from e81b7cc to 6562cac Compare May 14, 2025 07:17
@chenfeiz0326 chenfeiz0326 changed the title Cherry-pick the first batch of commits from feat/llama4 to main Cherry-pick commits from feat/llama4 to main May 14, 2025
@chenfeiz0326
chenfeiz0326 force-pushed the user/chenfeiz/cherry-pick-llama4-change-1 branch from 0341752 to e526f75 Compare May 19, 2025 13:43
Comment thread tensorrt_llm/_torch/modules/attention.py Outdated
@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list A100X-PyTorch-1

@chenfeiz0326
chenfeiz0326 force-pushed the user/chenfeiz/cherry-pick-llama4-change-1 branch from c5601d8 to 0c54c52 Compare May 26, 2025 09:32
@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6529 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6529 [ run ] completed with state FAILURE

@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6534 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6534 [ run ] completed with state FAILURE

@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6542 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6542 [ run ] completed with state FAILURE

@chenfeiz0326
chenfeiz0326 force-pushed the user/chenfeiz/cherry-pick-llama4-change-1 branch from 1b73c0b to e57733f Compare May 27, 2025 07:39
Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@chenfeiz0326
chenfeiz0326 force-pushed the user/chenfeiz/cherry-pick-llama4-change-1 branch from e57733f to 55761a9 Compare May 27, 2025 07:47
Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6603 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6603 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4828 completed with status: 'FAILURE'

@hlu1
hlu1 requested a review from yilin-void May 27, 2025 21:21
Comment thread tensorrt_llm/_torch/pyexecutor/model_engine.py
@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list A100X-PyTorch-1

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6696 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6696 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4891 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Chenfei Zhang <chenfeiz@nvidia.com>
@chenfeiz0326

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list A100X-PyTorch-1

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6724 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #6724 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4908 (Partly Tested) completed with status: 'SUCCESS'

@hlu1

hlu1 commented May 28, 2025

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Previously failed stage is successful in rerun"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants