fix potential issues in allreduce fusion kernel and ut - #4226
Conversation
|
/bot run --disable-fail-fast |
|
PR_Github #4860 [ run ] triggered by Bot |
|
PR_Github #4860 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #4947 [ run ] triggered by Bot |
|
/bot kill |
|
PR_Github #4964 [ kill ] triggered by Bot |
|
PR_Github #4947 [ run ] completed with state |
|
/bot run |
|
PR_Github #4964 [ kill ] completed with state |
|
PR_Github #4967 [ run ] triggered by Bot |
|
Some questions about these potential issues, not sure if I understand them correctly: |
|
PR_Github #4967 [ run ] completed with state |
|
hi @hyukn ,
This does not cause any problems at present, but customers have reported that this will cause compute-sanitizer to prompt misaligned address.
If the last 8 bytes of a consecutive 16-byte segment in the actual data, when interpreted as two floats, happen to be [-0.f, 0.f], it will cause a hang. However, this bug has not been observed to be triggered so far.
This issue is only relevant to the cpp unit test, in actual use, we will not use fp4 on pre-Blackwell. |
|
/bot run |
hyukn
left a comment
There was a problem hiding this comment.
Thanks a lot for the detailed explanation. LGTM.
|
PR_Github #5006 [ run ] triggered by Bot |
|
PR_Github #5006 [ run ] completed with state |
|
/bot run |
|
PR_Github #5119 [ run ] triggered by Bot |
|
PR_Github #5119 [ run ] completed with state |
|
/bot run |
|
PR_Github #5319 [ run ] triggered by Bot |
|
PR_Github #5319 [ run ] completed with state |
Signed-off-by: Yilin Zhang <18275976+yilin-void@users.noreply.github.com>
|
/bot run |
|
PR_Github #5676 [ run ] triggered by Bot |
|
PR_Github #5676 [ run ] completed with state |
potential issues:
float val[4]is not aligned to 16 bytes, which may result in a misaligned address when reinterpret_castvaltofloat4*.-0in the data.