Skip to content

[Feat] add chunked-attention kernels on Hopper (for llama4) - #4291

Merged
schetlur-nv merged 3 commits into
NVIDIA:mainfrom
PerkzZheng:user/perkzz/chunked-attention
May 19, 2025
Merged

[Feat] add chunked-attention kernels on Hopper (for llama4)#4291
schetlur-nv merged 3 commits into
NVIDIA:mainfrom
PerkzZheng:user/perkzz/chunked-attention

Conversation

@PerkzZheng

Copy link
Copy Markdown
Collaborator

Add chunked-attention kernels on Hopper (for llama4)

fmha_v2 commit: 6552b99d4820fa3f5e8a48a392681a8c128bf623

Description

Please explain the issue and the solution in short.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@PerkzZheng
PerkzZheng force-pushed the user/perkzz/chunked-attention branch from d9137aa to dede72b Compare May 14, 2025 07:24
@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5135 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5135 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3745 completed with status: 'FAILURE'

@PerkzZheng
PerkzZheng force-pushed the user/perkzz/chunked-attention branch from dede72b to 9948fe4 Compare May 14, 2025 11:42
@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5168 [ run ] triggered by Bot

@PerkzZheng
PerkzZheng force-pushed the user/perkzz/chunked-attention branch from 9948fe4 to 03cdd5a Compare May 14, 2025 14:08
@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5186 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5168 [ run ] completed with state ABORTED

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5186 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3784 completed with status: 'FAILURE'

@PerkzZheng
PerkzZheng force-pushed the user/perkzz/chunked-attention branch 2 times, most recently from 899df5b to 38d516c Compare May 15, 2025 00:25
@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5223 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5223 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #3815 completed with status: 'SUCCESS'

@PerkzZheng
PerkzZheng force-pushed the user/perkzz/chunked-attention branch from 38d516c to c7d0860 Compare May 15, 2025 06:30
@PerkzZheng
PerkzZheng requested review from mikeiovine and yuxianq May 15, 2025 06:33
Comment thread cpp/tensorrt_llm/common/attentionOp.cpp Outdated

@yuxianq yuxianq left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please ensure that #4117 is merged first.

@PerkzZheng
PerkzZheng force-pushed the user/perkzz/chunked-attention branch from c7d0860 to c8e678e Compare May 15, 2025 10:22
@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5337 [ run ] triggered by Bot

@PerkzZheng
PerkzZheng force-pushed the user/perkzz/chunked-attention branch from c8e678e to 0ecb8fa Compare May 15, 2025 13:48
@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5354 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5337 [ run ] completed with state ABORTED

@mikeiovine

Copy link
Copy Markdown
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5354 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3907 completed with status: 'FAILURE'

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5388 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5388 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #3932 completed with status: 'FAILURE'

@PerkzZheng
PerkzZheng force-pushed the user/perkzz/chunked-attention branch from 0ecb8fa to 982a864 Compare May 16, 2025 05:13
@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5454 [ run ] triggered by Bot

@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5501 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5454 [ run ] completed with state ABORTED

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5501 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4008 completed with status: 'FAILURE'

@PerkzZheng

Copy link
Copy Markdown
Collaborator Author

/bot run --only-multi-gpu-test

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5608 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5608 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4093 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Perkz Zheng <67892460+PerkzZheng@users.noreply.github.com>
… hopper fmha kernels

Signed-off-by: Perkz Zheng <67892460+PerkzZheng@users.noreply.github.com>
@EmmaQiaoCh
EmmaQiaoCh force-pushed the user/perkzz/chunked-attention branch from 8155e75 to 5303507 Compare May 19, 2025 09:09
@EmmaQiaoCh

Copy link
Copy Markdown
Collaborator

/bot run --only-multi-gpu-test

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5705 [ run ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5705 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #4171 (Partly Tested) completed with status: 'SUCCESS'

@schetlur-nv

Copy link
Copy Markdown
Collaborator

/bot reuse-pipeline

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5753 [ reuse-pipeline ] triggered by Bot

@schetlur-nv
schetlur-nv merged commit 1c5b0d6 into NVIDIA:main May 19, 2025
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5753 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #5705 (Partly Tested) for commit 0d57171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants