Skip to content

[TRTLLM-4638] feat(scaffolding): update Reward Controller to PRM specific controller with step split - #4337

Merged
dc3671 merged 1 commit into
NVIDIA:mainfrom
dc3671:update-prm-controller
May 19, 2025
Merged

[TRTLLM-4638] feat(scaffolding): update Reward Controller to PRM specific controller with step split#4337
dc3671 merged 1 commit into
NVIDIA:mainfrom
dc3671:update-prm-controller

Conversation

@dc3671

@dc3671 dc3671 commented May 15, 2025

Copy link
Copy Markdown
Collaborator

Description

PRM model should split steps first, and each prompt corresponds to a output, rather than all outputs.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@dc3671
dc3671 requested review from WeiHaocheng and dongxuy04 May 15, 2025 00:41
@dc3671
dc3671 force-pushed the update-prm-controller branch from 5a098d5 to e92dbdf Compare May 19, 2025 03:57
Comment thread tensorrt_llm/scaffolding/controller.py Outdated
with step split.

Signed-off-by: Zhenhuan Chen <chenzhh3671@gmail.com>
@dc3671
dc3671 force-pushed the update-prm-controller branch from e92dbdf to 3740002 Compare May 19, 2025 09:24
@dc3671

dc3671 commented May 19, 2025

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "only modify scaffolding code"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5708 [ skip ] triggered by Bot

@dc3671
dc3671 enabled auto-merge (squash) May 19, 2025 09:47
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #5708 [ skip ] completed with state SUCCESS
Skipping testing for commit 3740002

@dc3671
dc3671 merged commit e70a205 into NVIDIA:main May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants