[TRTLLM-3456] Speculation: Draft Target in new FW

[IzzyPutterman]

No description provided.

[mikeiovine]

Looks good. Let's add a test?

[mikeiovine]

By the way, I realized that this was a bit too specific to eagle 3: https://github.com/NVIDIA/TensorRT-LLM/blob/main/tensorrt_llm/_torch/pyexecutor/py_executor.py#L1817

You don't have to re-compute KV cache for verified tokens in this case; that's only a thing in MTP/eagle. We can make it optional. No need to fix this now since it's a performance thing, won't hurt correctness.

[IzzyPutterman]

Some variance in output is expected (I think) specifically when a draft token is from the prefill portion.

[IzzyPutterman]

Apparently I have found an edge case in the formatting :)

[Funatiq]

Apparently I have found an edge case in the formatting :)

I guess it was a conflict between yapf and isort or something similar? Could you please disable the formatting locally instead of changing the config file? Something like:

# isort: off
...
# isort: on

or

# yapf: disable
...
# yapf: enable

[IzzyPutterman]

Depends on these fixes: #4807

[IzzyPutterman]

/bot run --disable-fail-fast

[mikeiovine]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #8320 [ run ] triggered by Bot

[IzzyPutterman]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #8320 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6027 completed with status: 'FAILURE'

[IzzyPutterman]

/bot run --disable-fail-fast

[IzzyPutterman]

/bot run --disable-fail-fast

[IzzyPutterman]

/bot run --disable-fail-fast

[Funatiq]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #8517 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8517 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6176 completed with status: 'FAILURE'

[tensorrt-cicd]

PR_Github #8568 [ run ] completed with state ABORTED

[tensorrt-cicd]

PR_Github #8569 [ kill ] completed with state SUCCESS
Successfully killed previous jobs for commit a1cff6c

[tensorrt-cicd]

PR_Github #8570 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8570 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6216 completed with status: 'FAILURE'

[IzzyPutterman]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #8704 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8704 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6312 completed with status: 'FAILURE'

[Funatiq]

/bot run

[tensorrt-cicd]

PR_Github #8774 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8774 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6371 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

[IzzyPutterman]

/bot skip

[github-actions]

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[IzzyPutterman]

/bot skip "No major changes since last CI pass, just rebase"

[github-actions]

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[IzzyPutterman]

/bot skip --comment "No major changes since last CI pass, just rebase"

[tensorrt-cicd]

PR_Github #9054 [ skip ] triggered by Bot

[tensorrt-cicd]

PR_Github #9054 [ skip ] completed with state SUCCESS
Skipping testing for commit d6d087d