Skip to content

feat:[AutoDeploy] Support Quantized MoE matcher - 1 - #4968

Closed
Fridah-nv wants to merge 12 commits into
NVIDIA:mainfrom
nv-auto-deploy:user/fridah/moe-quant-match
Closed

feat:[AutoDeploy] Support Quantized MoE matcher - 1#4968
Fridah-nv wants to merge 12 commits into
NVIDIA:mainfrom
nv-auto-deploy:user/fridah/moe-quant-match

Conversation

@Fridah-nv

@Fridah-nv Fridah-nv commented Jun 6, 2025

Copy link
Copy Markdown
Collaborator

Description

Separate from #4361

TODO: update custom op names, update model coverage

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Fridah-nv
Fridah-nv requested a review from a team as a code owner June 6, 2025 00:23
@Fridah-nv
Fridah-nv requested a review from lucaslie June 6, 2025 00:23
@Fridah-nv
Fridah-nv force-pushed the user/fridah/moe-quant-match branch from 882fe0b to 122cafe Compare June 18, 2025 20:52
greg-kwasniewski1 and others added 10 commits June 24, 2025 15:27
* Fixed TP strong scaling if TP > num_kv_heads

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>

* Fixed test_graph_sharding. Attention uses simple_shard

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>

* head_dim inferred from the graph directly. Fixed test_graph_sharding.py

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>

* changed GQA block to fit column_row_shard heuristic requirements

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>

* Fixed parameter count

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>

---------

Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>
* auto_deploy: rename torch and triton custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename flashinfer custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename moe custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename distribution custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename distribution custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename linear custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename rope custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename mla custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: bug fixes

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename mla custom ops (2)

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename tirton rope custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename torch rope custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename triton attention custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: rename torch quantization custom ops

Signed-off-by: Neta Zmora <nzmora@nvidia.com>

* auto_deploy: fix failing multi-gpu tests

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* pre-commit formatting fixes

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* pre-commit formatting fixes

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* add a README for the custom ops

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* rename custom_ops/rope.py to custom_ops/triton_rope.py

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* separate moe custom backends to different files

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* pre-commit formatting fixes

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

---------

Signed-off-by: Neta Zmora <nzmora@nvidia.com>
Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>
In #61 I accidentally removed fused_moe.py
This PR fixes that and completes my intended change: split fused_moe.py to two files.

* add fused_moe.py which I accidentally removed

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* separate torch MOE custom ops to a separate file

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* separate trtllm MOE custom ops to a separate file

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

* remove unused imports

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>

---------

Signed-off-by: Neta Zmora <96238833+nzmora-nvidia@users.noreply.github.com>
…64), fixes NVIDIA#4841, fixes NVIDIA#5254

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Lucas Liebenwein <11156568+lucaslie@users.noreply.github.com>
…nit tests

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
…cc issue and e2e mixtral fp4 has kernel error wo moe matching

Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
@Fridah-nv
Fridah-nv force-pushed the user/fridah/moe-quant-match branch from 122cafe to 4f370f7 Compare June 27, 2025 18:16
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Frida Hou <201670829+Fridah-nv@users.noreply.github.com>
@Fridah-nv Fridah-nv closed this Jun 27, 2025
@github-project-automation github-project-automation Bot moved this from Backlog to Done in AutoDeploy Board Jun 27, 2025
@Fridah-nv

Copy link
Copy Markdown
Collaborator Author

Re opened in nv-auto-deploy#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants