refactor: remove TrtGptModelOptionalParams

[Funatiq]

Description

Remove TrtGptModelOptionalParams class. Use ExecutorConfig instead.

Test Coverage

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[Funatiq]

/bot run

[tensorrt-cicd]

PR_Github #8688 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8688 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6297 completed with status: 'FAILURE'

[Funatiq]

/bot run --stage-list "A10-CPP-1, A30-CPP-1, A30-CPP-2, H100_PCIe-CPP-1"

[Copilot]

Pull Request Overview

This PR refactors the codebase by removing the now‑redundant TrtGptModelOptionalParams and converting all its usages into the new ExecutorConfig. Key changes include updates to C++ unit tests, modifications in model factory functions and bindings, and adjustments in multiple header and implementation files to align with the new ExecutorConfig parameters.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
tests/unittest/bindings/test_bindings_ut.py	Removed tests specific to TrtGptModelOptionalParams.
cpp/tests/unit_tests/executor/executorTestSmallArbitraryOutputTensors.cpp	Updated model construction to pass ExecutorConfig instead of TrtGptModelOptionalParams.
cpp/tests/unit_tests/executor/executorTestSmall.cpp	Replaced optionalParams usage with ExecutorConfig.
cpp/tensorrt_llm/pybind/bindings.cpp	Removed Python bindings for TrtGptModelOptionalParams.
Multiple files under cpp/tensorrt_llm/batch_manager and cpp/tensorrt_llm/executor	Refactored to use ExecutorConfig for consistency in model initialization.

Comments suppressed due to low confidence (2)

cpp/tests/unit_tests/executor/executorTestSmallArbitraryOutputTensors.cpp:129

• Verify that the default boolean value ('false') passed as the final argument in the TrtGptModelInflightBatching constructor is correct and consistently applied across all model factory calls after replacing TrtGptModelOptionalParams with ExecutorConfig.

auto model = std::make_shared<batch_manager::TrtGptModelInflightBatching>(logger, modelConfig, worldConfig, engine, false, executorConfig, false);

cpp/tensorrt_llm/pybind/bindings.cpp:511

• Ensure that Python bindings for ExecutorConfig are provided to replace the removed TrtGptModelOptionalParams bindings so that Python users continue to have full functionality.

/* Removed TrtGptModelOptionalParams bindings block */

[tensorrt-cicd]

PR_Github #8742 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8742 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6345 (Partly Tested) completed with status: 'FAILURE'

[Funatiq]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #8788 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8788 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6384 completed with status: 'FAILURE'

[Funatiq]

/bot run

[tensorrt-cicd]

PR_Github #8816 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8816 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6404 completed with status: 'FAILURE'

[Funatiq]

/bot run

[tensorrt-cicd]

PR_Github #8835 [ run ] triggered by Bot

[Funatiq]

/bot run

[tensorrt-cicd]

PR_Github #8837 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8837 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6424 completed with status: 'FAILURE'

[Funatiq]

/bot run

[tensorrt-cicd]

PR_Github #8882 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8882 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6468 completed with status: 'FAILURE'

[Funatiq]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #8887 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #8887 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6472 completed with status: 'FAILURE'

[Funatiq]

/bot run --disable-fail-fast

[Funatiq]

/bot run

[tensorrt-cicd]

PR_Github #9059 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #9059 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #6624 completed with status: 'FAILURE'

[Funatiq]

/bot run

[tensorrt-cicd]

PR_Github #9133 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #9133 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #6686 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.