Skip to content

[feat] Sharding logic split to pattern detection and executor for EP and BMM (fixes #5916) - #6180

Closed
greg-kwasniewski1 wants to merge 21 commits into
NVIDIA:mainfrom
nv-auto-deploy:gk/sharding_config_v2
Closed

[feat] Sharding logic split to pattern detection and executor for EP and BMM (fixes #5916)#6180
greg-kwasniewski1 wants to merge 21 commits into
NVIDIA:mainfrom
nv-auto-deploy:gk/sharding_config_v2

Fixed sharding tests 1.1

9867368
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Jul 18, 2025 in 1s

DCO

There are 9 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~21 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin gk/sharding_config_v2

Summary

Commit sha: 2cf506b, Author: Fridah-nv, Committer: Lucas Liebenwein; Expected "Fridah-nv 201670829+Fridah-nv@users.noreply.github.com", but got "Frida Hou 201670829+Fridah-nv@users.noreply.github.com".
Commit sha: 6535ee6, Author: Fridah-nv, Committer: GitHub; Can not find "Fridah-nv 201670829+Fridah-nv@users.noreply.github.com", in ["Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com", "Frida Hou 201670829+Fridah-nv@users.noreply.github.com"].
Commit sha: dad1c62, Author: Gal Hubara-Agam, Committer: GitHub; Expected "Gal Hubara-Agam 96368689+galagam@users.noreply.github.com", but got "Gal Hubara Agam 96368689+galagam@users.noreply.github.com".
Commit sha: dc2f4fc, Author: Grzegorz Kwasniewski, Committer: GitHub; Can not find "Grzegorz Kwasniewski 213329731+greg-kwasniewski1@users.noreply.github.com", in ["greg-kwasniewski1 213329731+greg-kwasniewski1@users.noreply.github.com", "greg-kwasniewski1 213329731+greg-kwasniewski1@users.noreply.github.com", "greg-kwasniewski1 213329731+greg-kwasniewski1@users.noreply.github.com", "greg-kwasniewski1 213329731+greg-kwasniewski1@users.noreply.github.com", "greg-kwasniewski1 213329731+greg-kwasniewski1@users.noreply.github.com", "greg-kwasniewski1 213329731+greg-kwasniewski1@users.noreply.github.com"].
Commit sha: 3422896, Author: Lucas Liebenwein, Committer: GitHub; The sign-off is missing.
Commit sha: 600f26e, Author: Neta Zmora, Committer: GitHub; Can not find "Neta Zmora nzmora@nvidia.com", in ["Neta Zmora 96238833+nzmora-nvidia@users.noreply.github.com", "Neta Zmora 96238833+nzmora-nvidia@users.noreply.github.com", "Neta Zmora 96238833+nzmora-nvidia@users.noreply.github.com"].
Commit sha: 6758578, Author: Neta Zmora, Committer: GitHub; The sign-off is missing.
Commit sha: 8b68352, Author: Suyog Gupta, Committer: GitHub; Can not find "Suyog Gupta 41447211+suyoggupta@users.noreply.github.com", in ["Suyog Gupta suyogg@nvidia.com", "Suyog Gupta suyogg@nvidia.com"].
Commit sha: e84b319, Author: Suyog Gupta, Committer: GitHub; Can not find "Suyog Gupta 41447211+suyoggupta@users.noreply.github.com", in ["Suyog Gupta suyogg@nvidia.com", "Suyog Gupta suyogg@nvidia.com", "Suyog Gupta suyogg@nvidia.com", "Suyog Gupta suyogg@nvidia.com", "Suyog Gupta suyogg@nvidia.com", "Lucas Liebenwein 11156568+lucaslie@users.noreply.github.com", "Suyog Gupta suyogg@nvidia.com", "Lucas Liebenwein 11156568+lucaslie@users.noreply.github.com"].