Skip to content

[https://nvbugs/5472947][fix] wait on isend handles before reusing buffers #7462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amukkara merged 1 commit into from
Sep 3, 2025
Merged

[https://nvbugs/5472947][fix] wait on isend handles before reusing buffers #7462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions tensorrt_llm/_torch/pyexecutor/py_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,8 +859,7 @@ def _executor_loop_pp(self):
# Send tokens to next pp rank (w.r.t model forward direction)
# Second last rank does not need to since last rank has original decoded tokens
if not self.dist.is_second_last_pp_rank:
if self.send_handles[prev_microbatch_id] is not None:
self.send_handles[prev_microbatch_id].wait()
self.wait_on_pp_send_handles(prev_microbatch_id)
self.send_handles[
prev_microbatch_id] = self.dist.isend_object(
sample_state.host,
Expand Down Expand Up @@ -892,6 +891,8 @@ def _executor_loop_pp(self):
self.resource_manager.update_resources(
previous_scheduled_batch)
self._remove_inflight_ids(previous_scheduled_batch)

self.wait_on_pp_send_handles(prev_microbatch_id)
self.micro_batches[prev_microbatch_id] = None

if self.kv_cache_transceiver and self.ctx_in_transmission_requests:
Expand All @@ -905,6 +906,11 @@ def _executor_loop_pp(self):
self.active_requests,
previous_batch)

def wait_on_pp_send_handles(self, microbatch_id):
if self.send_handles[microbatch_id] is not None:
self.send_handles[microbatch_id].wait()
self.send_handles[microbatch_id] = None

def _prepare_and_schedule_batch(self):
new_requests = self._fetch_and_activate_new_requests()
if self.should_stop_processing:
Expand Down Expand Up @@ -1821,8 +1827,7 @@ def _handle_logits_communication(self, previous_batch, prev_microbatch_id):
req.py_result = py_result

elif self.dist.is_last_pp_rank and len(finished_reqs):
if self.send_handles[prev_microbatch_id] is not None:
self.send_handles[prev_microbatch_id].wait()
self.wait_on_pp_send_handles(prev_microbatch_id)
self.send_handles[prev_microbatch_id] = self.dist.isend_object(
[r.py_result for r in finished_reqs],
dest=self.dist.next_pp_rank,
Expand Down
Loading