[TRTLLM-7292][feat] Support manual gc in trtllm-serve - #7518
Conversation
3c2b47d to
72cd590
Compare
📝 WalkthroughWalkthroughAdds an import of the gc module and introduces conditional garbage collector disabling during server startup in the call(host, port) path(s) of tensorrt_llm/serve/openai_server.py, based on the TRTLLM_SERVE_ENABLE_GC environment variable set to "0". The logic appears in two call definitions before storing the binding address. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Admin as Admin/Runner
participant Server as OpenAI Server
participant Env as Environment
participant GC as Python GC
Admin->>Server: __call__(host, port)
Server->>Env: Read TRTLLM_SERVE_ENABLE_GC
alt GC disabled when "0"
Server->>GC: disable()
note right of Server: GC disabled for startup/runtime
else GC enabled otherwise
Server-->>GC: no-op
end
Server->>Server: Store binding address / continue init
Server-->>Admin: Startup proceeds
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tensorrt_llm/serve/openai_server.py (1)
744-749: Harden GC gating: robust env parsing and explicit startup logsAs written, only a literal "0" disables GC; values like "false"/"False" won’t, which can surprise operators. Also, logging the decision helps observability.
Apply this diff to make parsing resilient and to log the chosen policy:
- if os.environ.get("TRTLLM_SERVE_ENABLE_GC", "0") == "0": - gc.disable() + env_val = os.getenv("TRTLLM_SERVE_ENABLE_GC", "0").strip().lower() + enable_gc = env_val in ("1", "true", "yes", "on") + if not enable_gc: + if gc.isenabled(): + gc.disable() + logger.warning("TRT-LLM serve: Python GC disabled (TRTLLM_SERVE_ENABLE_GC=%r). Monitor process RSS.", env_val) + else: + logger.info("TRT-LLM serve: Python GC enabled (TRTLLM_SERVE_ENABLE_GC=%r).", env_val)Nit: in the preceding comments, consider “Disabling GC is quite aggressive …” and “re-enable GC by default” (instead of “straightup” / “enable GC by default”).
As a complementary shutdown hygiene (optional), after server teardown re-enable and collect once:
# after self.llm.shutdown() in the lifespan teardown try: if not gc.isenabled(): gc.enable() gc.collect() except Exception: pass
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
tensorrt_llm/serve/openai_server.py(2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tensorrt_llm/serve/openai_server.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tensorrt_llm/serve/openai_server.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tensorrt_llm/serve/openai_server.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tensorrt_llm/serve/openai_server.py (1)
3-3: LGTM: targeted import for GC controlImport is used only in the serve entry; looks good.
|
/bot run |
|
PR_Github #17795 [ run ] triggered by Bot |
|
PR_Github #17795 [ run ] completed with state |
|
/bot run |
1 similar comment
|
/bot run |
|
PR_Github #17804 [ run ] triggered by Bot |
|
PR_Github #17804 [ run ] completed with state |
|
/bot run |
|
PR_Github #17816 [ run ] triggered by Bot |
|
PR_Github #17816 [ run ] completed with state |
|
/bot run |
|
PR_Github #17827 [ run ] triggered by Bot |
72cd590 to
2edeb10
Compare
|
PR_Github #17827 [ run ] completed with state |
2edeb10 to
bc6b109
Compare
nv-yilinf
changed the title
|
/bot run |
|
PR_Github #18107 [ run ] triggered by Bot |
nv-yilinf
changed the title
Signed-off-by: Yilin Fan <206948969+nv-yilinf@users.noreply.github.com>
bc6b109 to
9387010
Compare
|
/bot run |
|
PR_Github #18120 [ run ] triggered by Bot |
|
PR_Github #18107 [ run ] completed with state |
|
PR_Github #18120 [ run ] completed with state |
|
Maybe we can close this one in favour of #7995? |
3 participants
@coderabbitai summary
Description
Test Coverage
existing tests
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.