Skip to content

[None][chroe] Update cron schedule for closing inactive issues - #8048

Merged
zhenhuaw-me merged 2 commits into
NVIDIA:mainfrom
zhenhuaw-me:skip-stale-check
Sep 29, 2025
Merged

[None][chroe] Update cron schedule for closing inactive issues#8048
zhenhuaw-me merged 2 commits into
NVIDIA:mainfrom
zhenhuaw-me:skip-stale-check

Conversation

@zhenhuaw-me

@zhenhuaw-me zhenhuaw-me commented Sep 29, 2025

Copy link
Copy Markdown
Member
  • Change cron schedule to run at 3 AM daily instead of hourly.
  • Only run in the official repo.

Example about the GitHub action (the recent 2 are skipped): https://github.com/zhenhuaw-me/TensorRT-LLM/actions/workflows/auto-close-inactive-issues.yml

Summary by CodeRabbit

  • Chores
    • Updated the inactive-issue automation to run once daily at 03:00 UTC instead of hourly, providing more predictable and less frequent notifications.
    • Limited the automation to the Nvidia/TensorRT-LLM repository to avoid unintended runs elsewhere.
    • Kept all existing steps, permissions, and messages unchanged—only timing and repository scope are affected.
    • Users will see stale/close actions processed in a single daily batch without changes to criteria or messaging.

* Change cron schedule to run at 3 AM daily instead of hourly.
* Only run in the official repo.

Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
@zhenhuaw-me
zhenhuaw-me requested a review from a team September 29, 2025 02:00
@zhenhuaw-me
zhenhuaw-me requested a review from a team as a code owner September 29, 2025 02:00
@coderabbitai

coderabbitai Bot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated the GitHub Actions workflow to change the scheduled run time and added a repository-specific guard on the stale job. No step logic, permissions, or messaging were altered.

Changes

Cohort / File(s) Summary
Workflow schedule and repo guard
\.github/workflows/auto-close-inactive-issues.yml
Changed cron from 0 * * * * to 0 3 * * *; added job-level condition to run only when github.repository == 'Nvidia/TensorRT-LLM'; retained existing steps and permissions.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    actor Scheduler as GitHub Scheduler (cron: 0 3 * * *)
    participant Workflow as Workflow: auto-close-inactive-issues.yml
    participant Job as Job: stale
    participant Steps as Steps: existing actions

    Scheduler->>Workflow: Trigger daily at 03:00 UTC
    Workflow->>Job: Evaluate job condition
    alt Repo is Nvidia/TensorRT-LLM
        Note right of Job: Repository-scoped guard passes
        Job->>Steps: Execute unchanged steps
    else Other repository
        Note right of Job: Guard fails — job skipped
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The pull request title follows the template’s summary of the change but the type “chroe” is misspelled and does not match the valid lowercase type “chore”. Please correct the type in the title from “[chroe]” to “[chore]” so that it follows the repository’s PR naming conventions.
Description Check ⚠️ Warning The PR description does not follow the repository’s required template: it lacks the “@coderabbitai summary” header, the structured “## Description”, “## Test Coverage”, and “## PR Checklist” sections, and clear statements for test coverage. Please update the PR description to include the “@coderabbitai summary” placeholder, add the “## Description” section explaining the issue and solution, list relevant tests under “## Test Coverage”, and verify the PR Checklist items as per the template.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28b9a81 and fa13470.

📒 Files selected for processing (1)
  • .github/workflows/auto-close-inactive-issues.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
.github/workflows/auto-close-inactive-issues.yml (1)

6-6: Confirm the intended 3 AM timezone

GitHub Actions cron expressions execute in UTC. If “3 AM daily” was meant in another timezone (for example, US Pacific), adjust the expression accordingly. (docs.github.com)

Comment thread .github/workflows/auto-close-inactive-issues.yml Outdated
Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
@zhenhuaw-me
zhenhuaw-me enabled auto-merge (squash) September 29, 2025 02:19
@chzblych

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Not tested by L0"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #20198 [ skip ] triggered by Bot

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #20198 [ skip ] completed with state SUCCESS
Skipping testing for commit 6b02ea6

@zhenhuaw-me
zhenhuaw-me merged commit 4be5331 into NVIDIA:main Sep 29, 2025
5 checks passed
@zhenhuaw-me
zhenhuaw-me deleted the skip-stale-check branch September 29, 2025 02:52
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
…A#8048)

Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
…A#8048)

Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
…A#8048)

Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
…A#8048)

Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants