[https://nvbugs/5470769][chore] unwaive test for PR7338 by reasonsolo · Pull Request #8258 · NVIDIA/TensorRT-LLM

reasonsolo · 2025-10-10T05:57:43Z

Summary by CodeRabbit

Tests
- Re-enabled previously skipped integration tests, expanding coverage for mixed-context generation scenarios.
- Improves CI validation and early detection of regressions by running tests that were previously waived.
- No changes to runtime behavior or user-facing functionality; impact is increased confidence in model accuracy and stability through broader test execution.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reasonsolo · 2025-10-10T05:58:23Z

/bot run

coderabbitai · 2025-10-10T06:00:07Z

📝 Walkthrough

Walkthrough

Removed two skip entries from tests/integration/test_lists/waives.txt, enabling previously skipped accuracy/disaggregated tests (TestQwen3_30B_A3B::test_mixed_ctx_gen_model[ctxpp2gentp2]) to run.

Changes

Cohort / File(s)	Summary
Test waivers update `tests/integration/test_lists/waives.txt`	Deleted two skip entries for TestQwen3_30B_A3B::test_mixed_ctx_gen_model[ctxpp2gentp2] in accuracy/disaggregated blocks, altering test selection to execute these tests.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer
    participant Runner as Test Runner
    participant Waives as waives.txt
    participant Test as TestQwen3_30B_A3B::test_mixed_ctx_gen_model[...]

    Dev->>Waives: Remove skip entries
    Runner->>Waives: Load skip list
    Waives-->>Runner: Updated list (no entries for target test)
    Runner->>Test: Schedule for execution
    Test-->>Runner: Run and report result

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description is mostly the unfilled template with placeholder headings and lacks any actual summary, explanation of the issue and solution, or test coverage details. Without these sections populated, reviewers have no context on why the tests were unwaived or which tests safeguard the change. This omission fails to meet the required structure and leaves critical information missing for assessment.	Please update the description by providing a concise summary of the change, a detailed explanation of why the tests are being unwaived, and a list of relevant test cases in the Test Coverage section.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title concisely indicates that a test previously waived under NVBugs ID 5470769 is being unwaived for PR7338, directly matching the core change in test skipping behavior. It uses the valid NVBugs ticket reference and correctly labels the change as a chore. As a result, the title is clear and specific enough for a teammate to understand the primary purpose of the pull request.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea640a1 and 1847c88.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt (0 hunks)

💤 Files with no reviewable changes (1)

tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-10-10T06:03:34Z

PR_Github #20973 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-10T07:17:51Z

PR_Github #20973 [ run ] completed with state SUCCESS
/LLM/release-1.1/L0_MergeRequest_PR pipeline #67 completed with status: 'FAILURE'

pcastonguay · 2025-10-10T12:17:07Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-10-10T12:23:02Z

PR_Github #21032 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-10T15:25:39Z

PR_Github #21032 [ run ] completed with state SUCCESS
/LLM/release-1.1/L0_MergeRequest_PR pipeline #81 completed with status: 'FAILURE'

pcastonguay · 2025-10-10T17:02:20Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-10-10T17:08:08Z

PR_Github #21043 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-10T19:51:53Z

PR_Github #21043 [ run ] completed with state FAILURE
/LLM/release-1.1/L0_MergeRequest_PR pipeline #84 completed with status: 'FAILURE'

reasonsolo · 2025-10-13T06:27:08Z

/bot run --disable-fail-fast

Signed-off-by: Lizhi Zhou <1432185+reasonsolo@users.noreply.github.com>

reasonsolo · 2025-10-13T06:27:22Z

/bot run --disable-fail-fast

tensorrt-cicd · 2025-10-13T06:32:42Z

PR_Github #21156 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-13T06:32:52Z

PR_Github #21157 [ run ] triggered by Bot

tensorrt-cicd · 2025-10-13T06:32:54Z

PR_Github #21156 [ run ] completed with state ABORTED

tensorrt-cicd · 2025-10-13T09:34:06Z

PR_Github #21157 [ run ] completed with state ABORTED
/LLM/release-1.1/L0_MergeRequest_PR pipeline #106 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

reasonsolo · 2025-10-14T01:58:21Z

/bot help

github-actions · 2025-10-14T01:58:29Z