[TRTLLM-8686][chore] Standardize LlmArgs initialization and parsing around Pydantic - #8331
Draft
anish-shanbhag wants to merge 15 commits into
Draft
[TRTLLM-8686][chore] Standardize LlmArgs initialization and parsing around Pydantic#8331anish-shanbhag wants to merge 15 commits into
anish-shanbhag wants to merge 15 commits into
Conversation
Draft
1 task
anish-shanbhag
changed the title
anish-shanbhag
force-pushed
the
standardize-llmargs-parsing
branch
from
November 1, 2025 01:09
bbc917a to
5cf680e
Compare
venkywonka
added a commit
to venkywonka/TensorRT-LLM
that referenced
this pull request
Nov 4, 2025
…trtllm-configure This commit enforces a standardized recipe schema and simplifies trtllm-configure to perform exact matching only, removing dynamic recipe generation. Schema Changes: - Rename 'config' → 'llm_api_config' in all recipe YAML files - Update recipe detection in trtllm-serve and trtllm-bench to use 'llm_api_config' - Update README examples to use new key name trtllm-configure Simplification: - Remove dynamic recipe generation using profiles - Implement exact matching only against tensorrt_llm/recipes/db/ - Add find_all_matching_recipes() to detect multiple matches - Return clear errors for no match or ambiguous (multiple) matches - Remove --profile CLI option (no longer needed) - Update help text and examples to reflect exact matching behavior Validation Changes: - Remove validate_llm_api_config() calls from configure/serve/bench - Comment out validation function pending PR NVIDIA#8331 - PR NVIDIA#8331 standardizes LlmArgs with Pydantic, after which validation will happen automatically when LlmArgs(**kwargs) is instantiated - Add TODO comments referencing PR NVIDIA#8331 Documentation Updates: - Remove "Profiles" section from README (no longer auto-generated) - Remove "Adding Custom Profiles" section - Update "Quick Start" to reflect exact matching behavior - Clarify that trtllm-configure retrieves (not generates) recipes Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
venkywonka
added a commit
to venkywonka/TensorRT-LLM
that referenced
this pull request
Nov 4, 2025
…trtllm-configure This commit enforces a standardized recipe schema and simplifies trtllm-configure to perform exact matching only, removing dynamic recipe generation. Schema Changes: - Rename 'config' → 'llm_api_config' in all recipe YAML files - Update recipe detection in trtllm-serve and trtllm-bench to use 'llm_api_config' - Update README examples to use new key name trtllm-configure Simplification: - Remove dynamic recipe generation using profiles - Implement exact matching only against tensorrt_llm/recipes/db/ - Add find_all_matching_recipes() to detect multiple matches - Return clear errors for no match or ambiguous (multiple) matches - Remove --profile CLI option (no longer needed) - Update help text and examples to reflect exact matching behavior Validation Changes: - Remove validate_llm_api_config() calls from configure/serve/bench - Comment out validation function pending PR NVIDIA#8331 - PR NVIDIA#8331 standardizes LlmArgs with Pydantic, after which validation will happen automatically when LlmArgs(**kwargs) is instantiated - Add TODO comments referencing PR NVIDIA#8331 Documentation Updates: - Remove "Profiles" section from README (no longer auto-generated) - Remove "Adding Custom Profiles" section - Update "Quick Start" to reflect exact matching behavior - Clarify that trtllm-configure retrieves (not generates) recipes Signed-off-by: Venky Ganesh <23023424+venkywonka@users.noreply.github.com>
6 tasks
6 tasks
anish-shanbhag
force-pushed
the
standardize-llmargs-parsing
branch
5 times, most recently
from
January 15, 2026 19:44
3fcccbf to
cb1b23a
Compare
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #32184 [ run ] triggered by Bot. Commit: |
anish-shanbhag
force-pushed
the
standardize-llmargs-parsing
branch
3 times, most recently
from
January 16, 2026 00:56
bbe3fc6 to
b3fa777
Compare
Collaborator
Author
|
/bot kill |
Collaborator
|
PR_Github #32193 [ kill ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #32193 [ kill ] completed with state |
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #32196 [ run ] triggered by Bot. Commit: |
Collaborator
Author
|
/bot run --disable-fail-fast |
anish-shanbhag
force-pushed
the
standardize-llmargs-parsing
branch
2 times, most recently
from
January 30, 2026 06:44
6c6ddf0 to
170cf0b
Compare
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #34184 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #34184 [ run ] completed with state
|
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #34186 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #34186 [ run ] completed with state
|
…ydantic Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
anish-shanbhag
force-pushed
the
standardize-llmargs-parsing
branch
from
January 30, 2026 21:16
3dea3ee to
1e9fdfa
Compare
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #34257 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #34257 [ run ] completed with state
|
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
This was referenced Feb 2, 2026
Signed-off-by: Anish Shanbhag <ashanbhag@nvidia.com>
LarryXFly
approved these changes
Feb 24, 2026
xinhe-nv
approved these changes
Feb 24, 2026
StanleySun639
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@coderabbitai summary
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.