Update Sample Custom Plugin README#2254
Open
the-david-oy wants to merge 2 commits into
Open
Conversation
the-david-oy
commented
Aug 17, 2022
the-david-oy
commented
- Fix DTRT_INCLUDE path
- Build Release instead of Debug version of plugin with all dependencies in the final .dll file
Contributor
|
|
the-david-oy
force-pushed
the
patch-1
branch
from
350450a to
5da6397
Compare
the-david-oy
force-pushed
the
patch-1
branch
from
5da6397 to
cc79e8c
Compare
Signed-off-by: David Yastremsky <dyastremsky@nvidia.com>
Author
|
Sure, done. |
Author
|
Pinging @samurdhikaru in case this is still valid. |
kevinch-nv
requested review from
LeoZDong and
kevinch-nv
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.