efficientNMSPlugin: support class-independent nms with new parameter class_agnostic#2645
Open
yili123123 wants to merge 3 commits into
Open
efficientNMSPlugin: support class-independent nms with new parameter class_agnostic#2645yili123123 wants to merge 3 commits into
yili123123 wants to merge 3 commits into
Conversation
…class_agnostic Signed-off-by: yili123123 <yiliyili123@outlook.com>
Signed-off-by: yili123123 <120350735+yili123123@users.noreply.github.com> Co-authored-by: Samurdhi Karunaratne <97725867+samurdhikaru@users.noreply.github.com>
|
Would really love to see this merged! This functionality would bring the behavior of NMS plugin in line with ONNX and pytorch. |
Signed-off-by: yili123123 <yiliyili123@outlook.com>
samurdhikaru
approved these changes
Feb 12, 2023
Collaborator
|
@yili123123 thanks for your contribution! We will merge this once the internal review/testing (currently in progress) is completed. @samurdhikaru will coordinate. |
Contributor
|
@yili123123 Please refer to 76eaca2 to see whether it fulfils the intended purpose. If not, please update the PR accordingly. |
Author
@samurdhikaru Okay, it fully meets expectations, is there anything else I need to do next? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rajeevsrao @pranavm-nvidia @samurdhikaru ,sorry for closing the previous pull request by mistake. Could you take your time to review the new PR?