[Common] Fix Build: NCCL EP build to respect MAX_JOBS - #3138
Conversation
nproc from parallel make for NCCL EP buildnproc from parallel make for NCCL EP build
|
/te-ci L0 |
Greptile SummaryThis PR updates the NCCL EP build in
Confidence Score: 4/5Safe to merge if the When no job-limit environment variable is set, setup.py — the make invocation needs the same Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[build_nccl_ep_submodule] --> B[get_max_jobs_for_parallel_build]
B --> C{env var set?}
C -->|NVTE_BUILD_MAX_JOBS or MAX_JOBS| D[return N gt 0]
C -->|none set| E[return 0]
D --> F["make -j N (correct)"]
E --> G["make -j 0 (undefined behavior)"]
style G fill:#f66,color:#fff
Reviews (3): Last reviewed commit: "Merge branch 'main' into te_ep/fix_build" | Re-trigger Greptile |
nproc from parallel make for NCCL EP buildMAX_JOBS
timmoon10
left a comment
There was a problem hiding this comment.
The fix at #3034 (comment) will reuse our existing infrastructure.
|
/te-ci L0 |
Description
NCCL EP build to respect MAX_JOBS.
Type of change
Checklist: