Skip to content

[PyTorch][torch.compile] Add TensorProto mechanism - #3153

Merged
ptrendx merged 35 commits into
NVIDIA:mainfrom
pggPL:tensor_proto_mechanism
Aug 5, 2026
Merged

[PyTorch][torch.compile] Add TensorProto mechanism#3153
ptrendx merged 35 commits into
NVIDIA:mainfrom
pggPL:tensor_proto_mechanism

Conversation

@pggPL

@pggPL pggPL commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR introduces TensorSpec — a data-free description of a tensor (or quantized tensor) that captures everything needed to rebuild it without holding any storage: its logical shape/dtype and, for quantized tensors, the value-opaque quantizer that defines the buffer layout.

The key property is that TensorSpec.create_tensor() materializes a quantized tensor purely in Python — via Quantizer.alloc_tensors plus the storage's __tensor_unflatten__ — so it traces under torch.compile(fullgraph=True) with no graph break, unlike make_empty, which goes through the opaque C++ tex.create_empty_quantized_tensor. This is the foundation for writing torch.library custom-op fake implementations of quantized ops; the consumers land in the follow-up Linear custom-op PR.

This builds on the value-opaque quantizer work, so a TensorSpec is itself safe to treat as a compile-time constant.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

dynamo/tensor_spec.py (new) — TensorSpec dataclass (shape, dtype, quantizer, requires_grad, device) with is_quantized, update_usage(), inner_names(), create_metadata(), create_inner_tensors(), assemble() and create_tensor(), plus a to_tensor_spec() helper that builds a spec from a plain torch.Tensor, a QuantizedTensorStorage or a QuantizedTensor. Exported from transformer_engine.pytorch.dynamo.

quantized_tensor.py

  • Add the PyTorch wrapper-subclass flatten protocol (__tensor_flatten__ / __tensor_unflatten__) to QuantizedTensorStorage.
  • Declare the flat buffers on the field itself: _scale_inv: Annotated[torch.Tensor, InnerTensor("fp8_scale_inv")]. __init_subclass__ collects these into _INNER_TENSORS in field order, so the attribute-to-constructor-kwarg mapping lives next to the attribute instead of in a parallel tuple.
  • The flatten context carries the storage class itself, so __tensor_unflatten__ needs no registry lookup.
  • Add pure-Python, traceable allocation primitives to Quantizer: inner_tensor_specs (buffer geometry), storage_metadata (concrete class + non-tensor constructor kwargs), and the alloc_tensors / create_metadata built on top of them. The base implementations raise NotImplementedError, so a quantizer that does not implement them simply cannot be used with TensorSpec.
  • Add a shape property that is valid on bare storages as well as wrapper tensors.

Quantizers — implement inner_tensor_specs and storage_metadata for Float8CurrentScalingQuantizer, MXFP8Quantizer, Float8BlockQuantizer and NVFP4Quantizer. The FP8 description mirrors the C++ allocation in csrc/quantizer.cpp, including the non-TN-capable-arch case where a single _data buffer backs both directions.

Storage classes — declare InnerTensor fields for Float8TensorStorage, MXFP8TensorStorage, Float8BlockwiseQTensorStorage and NVFP4TensorStorage.

module/base.py — override nn.Module._apply in TransformerEngineBaseModule. This is a consequence of the flatten protocol, not part of the new API: once a parameter implements it, _apply moves the parameter with torch.utils.swap_tensors, which exchanges its whole __dict__. Inner buffers ride across correctly, but state attached from the outside (_high_precision_init_val and its accessors, main_grad, user attributes) would be left behind on the discarded tensor. The override snapshots those attributes and re-attaches the ones the swap did not carry over, restoring the pre-PR behaviour of .to() / .cuda() / .half().

Tests

  • tests/pytorch/test_torch_compile.py: quantizer primitives under FakeTensorMode, storage flatten/unflatten round-trip, TensorSpec behaviour in eager and fake mode, fullgraph=True tracing, and to_tensor_spec round-trips — across FP8 current scaling, MXFP8, FP8 blockwise and NVFP4.
  • test_python_alloc_matches_cpp_make_empty builds the same tensor twice, via make_empty (C++) and via the Python primitives, then checks structural parity (class, buffer set, per-buffer shape/dtype/device, logical shape/dtype, flatten context) and functional parity — the real quantize kernel writes bit-identical results into both — across quantizer families x rowwise/columnwise x wrapper/internal.
  • tests/pytorch/test_sanity.py: attributes attached to a quantized parameter survive nn.Module._apply for .cuda(), .cpu() and .half().

Known limitations

  • The flatten protocol covers the four storage classes listed above. HybridQuantizedTensorStorage and IdentityTensorStorage declare no InnerTensor fields, so flattening them raises rather than silently passing their buffers through the context; hybrid storage holds nested storages rather than flat buffers, which the current model does not express.
  • HybridQuantizer and IdentityQuantizer are not registered as value-opaque quantizers.
  • Single-device only; tensor/sequence-parallel shape effects are not modelled.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pggPL
pggPL requested a review from ksivaman as a code owner June 29, 2026 09:39
@greptile-apps

greptile-apps Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR introduces TensorSpec — a data-free description of a tensor (plain or quantized) that captures shape, dtype, and quantizer, enabling torch.compile(fullgraph=True)-traceable allocation of quantized tensors via pure Python (alloc_tensors + storage __tensor_flatten__/__tensor_unflatten__) rather than the opaque C++ create_empty_quantized_tensor. It also fixes a swap_tensors-driven attribute loss on TransformerEngineBaseModule._apply.

  • TensorSpec / to_tensor_spec (dynamo/tensor_spec.py): data-free spec with create_tensor() that traces under fullgraph=True; to_tensor_spec is documented to work on bare QuantizedTensorStorage but fails with AttributeError because tensor.device is not defined on bare storages.
  • Flatten protocol (quantized_tensor.py): InnerTensor annotation marker drives __init_subclass__-collected _INNER_TENSORS; __tensor_flatten__/__tensor_unflatten__ on QuantizedTensorStorage; Quantizer allocation hooks implemented for all four quantizer types.
  • _apply fix (module/base.py): snapshots parameter __dict__ before _apply and re-attaches missing keys after swap_tensors; handles only _parameters, not _buffers.

Confidence Score: 4/5

Safe to merge with a targeted fix; to_tensor_spec on a bare storage will raise AttributeError at runtime.

The core TensorSpec machinery, flatten protocol, and _apply fix are well-designed and well-tested. The one concrete defect is in to_tensor_spec: it accesses tensor.device unconditionally, but bare QuantizedTensorStorage objects have no device attribute. The PR added a shape property and a _dtype fallback for bare storages, making the missing device an oversight. The current test suite avoids this path, so there is no regression guard.

Files Needing Attention: transformer_engine/pytorch/dynamo/tensor_spec.py needs a device guard for bare storages. transformer_engine/pytorch/quantized_tensor.py — the get_type_hints ordering assumption in _collect_inner_tensor_fields should be documented for future subclass authors.

Important Files Changed

Filename Overview
transformer_engine/pytorch/dynamo/tensor_spec.py New TensorSpec dataclass and to_tensor_spec helper. to_tensor_spec fails with AttributeError when called on a bare QuantizedTensorStorage because it accesses tensor.device which is not defined on bare storages; shape was covered but device was not.
transformer_engine/pytorch/quantized_tensor.py Adds InnerTensor annotation marker, _collect_inner_tensor_fields, QuantizedTensorStorage.shape property, __init_subclass__-driven _INNER_TENSORS, __tensor_flatten__/__tensor_unflatten__, and pure-Python allocation primitives on Quantizer. Implementation is correct but relies on get_type_hints MRO order for _INNER_TENSORS which is implicitly fragile for future subclasses.
transformer_engine/pytorch/module/base.py Adds _apply override to re-attach externally-bound attributes lost during swap_tensors. Handles parameters only; registered QuantizedTensorStorage buffers are not snapshotted.
transformer_engine/pytorch/tensor/float8_tensor.py Adds storage_metadata and inner_tensor_specs to Float8CurrentScalingQuantizer, correctly handling the non-TN (Blackwell+) path where _data backs both usages.
transformer_engine/pytorch/tensor/nvfp4_tensor.py Adds storage_metadata and inner_tensor_specs to NVFP4Quantizer. Uses type(self) to call @staticmethods (correct workaround for PyTorch guard issue #182741).
tests/pytorch/test_torch_compile.py Adds comprehensive TensorSpec tests covering all four quantizer types and three usage combos with fullgraph=True compile validation.

Sequence Diagram

sequenceDiagram
    participant User
    participant TensorSpec
    participant Quantizer
    participant Storage as QuantizedTensorStorage

    User->>TensorSpec: TensorSpec(shape, dtype, quantizer)
    TensorSpec->>Quantizer: copy() [isolate usage mutations]

    User->>TensorSpec: create_tensor()
    TensorSpec->>TensorSpec: create_inner_tensors()
    TensorSpec->>Quantizer: alloc_tensors(shape, device)
    Quantizer->>Quantizer: inner_tensor_specs(shape)
    Quantizer-->>TensorSpec: "{attr: Tensor} inner tensors"

    TensorSpec->>TensorSpec: assemble(inner_tensors)
    TensorSpec->>Quantizer: create_metadata(shape, dtype)
    Quantizer->>Quantizer: storage_metadata(dtype)
    Quantizer-->>TensorSpec: "ctx {cls, is_tensor, nontensor_kwargs}"

    TensorSpec->>Storage: cls.__tensor_unflatten__(inner, ctx, shape, stride)
    Storage-->>TensorSpec: QuantizedTensor / QuantizedTensorStorage
    TensorSpec-->>User: materialized tensor (FakeTensor under FakeTensorMode)
Loading

Reviews (22): Last reviewed commit: "Merge branch 'main' into tensor_proto_me..." | Re-trigger Greptile

Comment thread transformer_engine/pytorch/tensor/mxfp8_tensor.py Outdated
Comment thread transformer_engine/pytorch/dynamo/tensor_proto.py Outdated
@pggPL
pggPL force-pushed the tensor_proto_mechanism branch 8 times, most recently from 9e78a6c to 50c11cd Compare June 29, 2026 13:46
Comment thread transformer_engine/pytorch/tensor/nvfp4_tensor.py Outdated
pggPL and others added 5 commits July 7, 2026 11:54
Squashed PR #8 (tensor_proto_mechanism) onto the rebased base. Adds TensorProto
(pure-Python, torch.compile-traceable quantized-tensor allocation via
Quantizer.alloc_tensors + storage __tensor_flatten__/__tensor_unflatten__),
Linear fake fwd/bwd impls for the custom-op path, and tests.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
The cached FP8 weight is the same tensor returned as new_weight_workspace (cache miss) or passed in as weight_workspace (cache hit). A custom op may not return a tensor that aliases an input or another return, so mark those slots and reconstruct wt_save in _linear_setup_ctx instead of saving it twice. Mirrored in the fake impl so the saved-slot layout matches.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
NVFP4Quantizer._describe_buffers grouped each amax right after its scale (per-usage), diverging from NVFP4TensorStorage._FLATTEN_TENSOR_BUFFERS (amax buffers last). The order is functionally irrelevant (buffers are consumed by name in alloc_tensors and reordered in TensorProto.inner_names), but aligning it makes describe/flatten agree and fixes test_to_tensor_proto_quantized[nvfp4].

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
…upport

- TensorProto.inner_names now raises if the quantizer describes buffer(s) absent
  from the storage's _FLATTEN_TENSOR_BUFFERS, instead of silently appending them.
- Gate the nvfp4 proto-quantizer param on nvfp4_available so it skips on hardware
  without NVFP4 support rather than failing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
…escribe_buffers

Access NVFP4Quantizer @staticmethods (convert_shape_for_fp4, get_columnwise_shape)
via the class instead of the instance. Under torch.compile, instance access of a
@staticmethod on a value-opaque object crashes Dynamo guard generation with
"'function' object has no attribute '__func__'" (pytorch/pytorch#182741).
Temporary workaround until the PyTorch-side fix lands.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
@pggPL
pggPL force-pushed the tensor_proto_mechanism branch from ff48e52 to e36cf6d Compare July 7, 2026 10:04
Comment thread transformer_engine/pytorch/tensor/nvfp4_tensor.py Outdated
pggPL added 10 commits July 13, 2026 10:47
The union is intentional: fields may carry bare QuantizedTensorStorage
objects (internal-quantizer optimization), and the annotation is
introspected in the follow-up custom-op PR to build the op schema with
flatten/unflatten slots. Also note the size()/.shape asymmetry and how
TensorProto handles it.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Make .shape valid on bare storages (derived from size()), so Tensor,
QuantizedTensor, bare storage and TensorProto all expose the same
attribute. Wrapper subclasses defer to the native TensorBase.shape.
Simplifies the shape fallback in to_tensor_proto.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Address review: build the same quantized tensor via make_empty (C++,
tex.create_empty_quantized_tensor) and via the Python primitives
(_describe_buffers + create_metadata + alloc_tensors +
__tensor_unflatten__) and check structural parity (class, buffer set,
per-buffer shape/dtype/device, flatten context) and functional parity
(the real quantize kernel writes bit-identical results into both,
dequantize matches), across quantizer families x rowwise/columnwise
x wrapper/internal.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Address review: the change stands on its own as a correctness fix;
drop the detailed (and imprecise) fake-impl/cudagraph justification.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Address review: wt_save is known non-None past the first branch, so
'X is not None and wt_save is X' reduces to 'wt_save is X'.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Address review: replace the local _contiguous_stride helper with the
torch one (stable at this path since v1.13); it also matches the ATen
contiguous-stride convention for zero-size dims and handles SymInts.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Address review: a silent no-op diverges from the real object's
behavior (plain torch.Tensor has no update_usage), which is exactly
the class of fake/real mismatches the proto is meant to avoid.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Address review: after the QuantizedTensorStorage.shape property the
storage and plain-tensor paths differed only in getattr fallbacks
(dtype/_dtype, _quantizer), which work uniformly for all input kinds;
drop the isinstance branch and the local import it needed.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Address review: the saved_weight slot is unconditionally aliased to
the weight parameter in forward, so it is never None in backward.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Comment thread tests/pytorch/test_torch_compile.py Outdated
pggPL added 5 commits July 28, 2026 14:21
test_python_alloc_matches_cpp_make_empty compared buffers the quantize
kernel never writes: the scale-inv padding is allocated uninitialized by
both paths, so the bit-exact comparison saw random bytes and failed on
H100/B200 for fp8_blockwise. Zero every buffer before quantizing, so the
comparison covers kernel output only.

Also drop the param-level skips on the nvfp4 entries of _PROTO_QUANTIZERS
and _VALUE_QUANTIZERS. is_fp8_available() and friends run at import time
and go through torch.cuda.current_device(), so this module cannot be
collected without CUDA at all and skipif(not torch.cuda.is_available())
never fires; the same goes for the torch.cuda.is_available() halves of
the _hw_available() guards. Gating nvfp4 on nvfp4_available was also
inconsistent with MXFP8 and blockwise, which are gated at runtime and
only in the tests that run a kernel -- the allocation primitives
themselves are pure Python and describe the layout on any HW.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
_linear_forward_impl_fake diverged from quantize_weight on the weight
workspace in three ways:

- it produced a new workspace only when update_ws was true, but the real
  cache-miss path returns (out, out) whenever cache=True, regardless of
  update_workspace; a first call with is_first_microbatch=False therefore
  lost the workspace and the "new_workspace" saved-weight alias;
- it treated any non-None cached workspace as a hit, while the real path
  runs _is_weight_workspace_valid() first and falls through to a miss when
  the cached buffer layout no longer matches the quantizer's usage;
- it kept quantizer.internal, so the descriptor resolved to a bare storage
  class, while the real path quantizes persistent workspaces with
  internal=False and caches wrapper tensors.

On a cache hit the weightmat is now the workspace descriptor itself, and on
a miss with cache_weight it is the same proto object returned as the new
workspace, matching quantize_weight's aliasing.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Eager forward forces save_original_input=False for
backward_override="dequantized", but the fake only handled
"high_precision". With save_original_input=True and that override, the
fake aliased the original input into saved-tensor slot 0 while eager saved
a quantized input with rowwise-only usage, so the saved payload layout and
the compiled backward setup disagreed.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
The output proto's requires_grad considered only the input and the weight,
so a frozen input and weight with a trainable bias described the output as
non-differentiable while eager _Linear.apply produces a differentiable one.
bias_requires_grad is already False when there is no bias.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
@pggPL

pggPL commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci pytorch

_linear_forward_impl_fake / _linear_backward_impl_fake, and the eager-side
changes that existed only to support them (reading the requires_grad flags
off LinearFwdArgs, the new_workspace/weight_workspace alias dedup and the
_linear_setup_ctx signature carrying (out, new_weight_workspace)), have no
caller in this PR: nothing registers them as a custom op's fake, so nothing
exercises them here.

They belong with the custom-op registration that consumes them. This PR is
left as the TensorProto mechanism proper -- the proto, the storage flatten
protocol and the pure-Python quantizer allocation hooks -- which the new
tests do cover. linear.py returns to its upstream state.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
@pggPL

pggPL commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci pytorch

Quantized tensors now implement the wrapper-subclass flatten protocol, so
nn.Module._apply moves them with torch.utils.swap_tensors instead of the
`param.data = ...` path. The swap exchanges the parameter's entire __dict__:
that is how the inner buffers reach the surviving object, but it also carries
off everything attached to the parameter from the outside.

TE relies on several such attributes: _high_precision_init_val and its two
accessors (quantized_model_init(preserve_high_precision_init_val=True)), plus
main_grad, grad_added_to_main_grad and overwrite_main_grad, which Megatron-Core
attaches. They survived before only because `param.data = ...` is a no-op for a
wrapper subclass -- the outer tensor is a zero-storage shell and the assignment
never touched __dict__, so device moves silently did nothing at all.

Snapshot the parameters' __dict__ before delegating to nn.Module._apply and
restore the entries the swap dropped, rebinding bound accessors to the
surviving parameter. Entries still present afterwards are the tensor's own
state, where the post-swap value is the correct one.

Covers the two test_sanity grouped-linear high-precision-init tests that broke
on B200, and adds a direct test over .cuda() / .cpu() / .half().

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
@pggPL

pggPL commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci pytorch L1

pggPL added a commit to pggPL/TransformerEngine that referenced this pull request Jul 29, 2026
Carried over from the TensorProto PR (NVIDIA#3153), where these impls used to
live without a caller; they belong here, with the custom-op registration
that consumes them.

- Weight workspace: quantize_weight returns a fresh workspace on every
  cache miss with cache=True, not only when update_workspace is set; it
  discards a cached workspace that fails _is_weight_workspace_valid; and it
  quantizes persistent workspaces with internal=False so the cache holds
  wrapper tensors. The fake did none of the three.
- backward_override="dequantized" forces save_original_input=False in the
  eager forward; the fake only handled "high_precision", so it aliased the
  original input where eager saves a rowwise-only quantized one.
- The output's requires_grad ignored the bias, describing the output of a
  bias-only-trainable Linear as non-differentiable.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
pggPL added 7 commits July 29, 2026 13:53
The restore loop keys off "present after the swap": what survived is the
tensor's own state, what did not is an externally attached annotation. That
holds only as long as every declared buffer really is present afterwards. If
one were not, the loop would quietly put the pre-move value back and splice a
buffer from the old device (or from before a dtype conversion) into the moved
parameter -- silently wrong numerics rather than a crash.

Raise instead when a name from _FLATTEN_TENSOR_BUFFERS is about to be restored.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
nn.Module._apply only assigns to self._parameters, never removes entries, so a
missing parameter after it returns means something unexpected happened. Skipping
it silently dropped every attribute attached to that parameter -- the failure
this override exists to prevent. Match the buffer check and fail loudly.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Reverts 6e61d36. The check guarded a case that cannot arise today: the
storages always set every declared buffer attribute, to None when unused, so
the key is present whatever the usage flags say.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Each storage class listed its tensor buffers twice: once as a field
annotation, once as an (attribute, constructor kwarg) pair in
_FLATTEN_TENSOR_BUFFERS, in a different order and further down the file.
Adding a buffer meant remembering both.

Mark the field instead -- _scale_inv: Annotated[torch.Tensor,
Buffer("fp8_scale_inv")] -- and collect the declarations in
__init_subclass__, which already runs there for the storage registry.
_FLATTEN_TENSOR_BUFFERS survives as the derived attribute, so every consumer
is untouched, and the collected values are identical to the hand-written
tuples for all nine registered classes.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
"Buffer" collides with nn.Module's buffers, which are a different thing, and
_FLATTEN_TENSOR_BUFFERS named a consumer (__tensor_flatten__) rather than the
thing itself -- the list has four of them. PyTorch calls exactly this concept
"inner tensors", which TensorProto.inner_names() already follows.

Also drop the underscore from the two hooks every quantizer has to implement.
They were the only members of the extension contract marked private, which is
why the tests needed seven protected-access waivers to call them; the members
nobody overrides (alloc_tensors, create_metadata) were public already.

  Buffer                  -> InnerTensor
  _FLATTEN_TENSOR_BUFFERS -> _INNER_TENSORS
  _describe_buffers       -> inner_tensor_specs
  _storage_metadata       -> storage_metadata

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
__tensor_flatten__ put the class qualname in the context and
__tensor_unflatten__ looked it up in a module-level registry, populated from
__init_subclass__. The indirection bought nothing: dynamo bakes the class
object into the graph as a constant just as happily, which is what the
custom-op branch already relies on.

Store type(self) directly and drop _STORAGE_REGISTRY. __init_subclass__ stays
for collecting the InnerTensor field annotations.

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
@pggPL

pggPL commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

/te-ci pytorch L1

Comment thread tests/pytorch/test_torch_compile.py Outdated
Comment thread tests/pytorch/test_torch_compile.py Outdated
Comment thread tests/pytorch/test_torch_compile.py Outdated


@dataclass
class TensorProto:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more general question - considering that PyTorch went with Tensor/FakeTensor naming, shouldn't we
follow suit with QuantizedTensor/FakeQuantizedTensor rather than introducing a completely new name?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, because TensorProto represents both Tensor and QuantizedTensor. I changed the name to TensorSpec.

Comment thread transformer_engine/pytorch/dynamo/tensor_spec.py
pggPL and others added 3 commits August 4, 2026 13:56
Addresses the latest review round:

- Rename TensorProto -> TensorSpec, to_tensor_proto -> to_tensor_spec and
  dynamo/tensor_proto.py -> dynamo/tensor_spec.py. "Proto" collided with
  ONNX/protobuf and invented a new term for something PyTorch already has
  vocabulary for; "spec" matches DTensorSpec / tf.TensorSpec. It is not a
  tensor subclass and it is not fake-specific (create_tensor() in eager
  builds a real tensor), so FakeQuantizedTensor would not fit.

- inner_names(): verify that inner_tensor_specs follows the storage's
  _INNER_TENSORS order instead of silently reordering. All four quantizers
  already emit that order, so the reorder was a no-op and the docstring
  rationale (NVFP4 grouping amax after each scale) was stale. A quantizer
  that breaks the contract now fails loudly instead of being papered over.

- Use the real availability reasons (reason_for_no_nvfp4,
  reason_for_no_fp8_block_scaling) in _skip_if_dequantize_unsupported
  instead of hardcoded strings.

- Speak of "inner tensors" consistently instead of "buffers", matching
  _INNER_TENSORS / inner_tensor_specs / create_inner_tensors.

- Fold test_tensor_spec_create_tensor_{eager,fake} into one test
  parametrized on fake, and drop test_primitives_unflatten_compiles: its
  production-code coverage is a subset of
  test_tensor_spec_create_tensor_compiles, the only part unique to it
  being the test helper's meta-device stride computation.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
… rename

The previous commit renamed "buffers" to "inner tensors"/"specs" with a
word-boundary substitution, which also rewrote three comments in code this
PR does not touch: the GPU-buffers and FP8-buffers notes in float8_tensor
and the device-inference note in mxfp8_tensor. Restore their original
wording.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Three conflicts, all "both sides added code in the same spot", resolved by
keeping both:

- quantized_tensor.py: main's FSDP2 buffer protocol next to this branch's
  subclass flatten protocol.
- float8_tensor.py: main's is_requantization_safe next to the quantizer's
  storage_metadata / inner_tensor_specs.
- storage/float8_tensor_storage.py: import line, both InnerTensor and
  _resolve_view_shape.

The new storages main brings in (HybridQuantizedTensorStorage,
IdentityTensorStorage) declare no InnerTensor fields and are deliberately
not covered by the flatten protocol.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
@ptrendx

ptrendx commented Aug 4, 2026

Copy link
Copy Markdown
Member

/te-ci pytorch

@ptrendx
ptrendx merged commit bf4b2b9 into NVIDIA:main Aug 5, 2026
21 of 26 checks passed
pggPL added a commit to pggPL/TransformerEngine that referenced this pull request Aug 5, 2026
Register the Linear forward/backward as torch.library custom ops on top of
the TensorSpec mechanism (NVIDIA#3153), so Linear traces under fullgraph compile
with FP8/MXFP8/NVFP4 recipes.

- transformer_engine/pytorch/dynamo/custom_op.py: custom-op registration
  framework (arg bundles, fake impls, autograd wiring)
- module/linear.py: split forward into compute + ctx save, fake forward/backward
- tests/pytorch/test_torch_compile.py: coverage for the compiled path

Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants