Skip MXFP8 MFSDP tests on hopper - #3163
Conversation
Signed-off-by: Varun Thumbe <vthumbe@nvidia.com>
Greptile SummaryThis PR adds an early-exit guard to
Confidence Score: 5/5The change is a small, self-contained guard that only adds a skip-path; it cannot affect test execution on Blackwell or cause regressions on passing hardware. The guard logic is correct for all known GPU generations: decimal stripping and integer comparison handle Hopper (9.0→90), Ada (8.9→89), and Blackwell (10.0→100) properly. The one improvement noted (checking the minimum across all GPUs rather than just GPU 0) matters only on heterogeneous nodes, which are uncommon in CI, so the change is safe to merge as-is. No files require special attention; the single changed file is a QA shell script with straightforward logic. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[test.sh starts] --> B[nvidia-smi query compute_cap of GPU 0]
B --> C[Strip non-digits: e.g. '9.0' → '90', '10.0' → '100']
C --> D{DEVICE_ARCH empty\nor < 100?}
D -- Yes --> E[Print skip message\nwith raw compute_cap\nexit 0]
D -- No --> F[Continue: setup Megatron-LM\nclone, vocab, env vars]
F --> G[Launch distributed GPT\npretrain with --fp8-recipe mxfp8]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[test.sh starts] --> B[nvidia-smi query compute_cap of GPU 0]
B --> C[Strip non-digits: e.g. '9.0' → '90', '10.0' → '100']
C --> D{DEVICE_ARCH empty\nor < 100?}
D -- Yes --> E[Print skip message\nwith raw compute_cap\nexit 0]
D -- No --> F[Continue: setup Megatron-LM\nclone, vocab, env vars]
F --> G[Launch distributed GPT\npretrain with --fp8-recipe mxfp8]
Reviews (2): Last reviewed commit: "Update qa/L1_pytorch_mcore_fsdp_integrat..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: vthumbe1503 <vthumbe@nvidia.com>
cspades
left a comment
There was a problem hiding this comment.
LGTM, I didn't add any device checks to this test.
|
/te-ci L1 |
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: